Community
Participate
Working Groups
Target for 3.1.1 release (NL release). In Eclipse 3.1, icons are being supplied for BiDi locales that will appear as if the icon has been reversed. For all plugins that supply icons, some code changes are required to support this that do not appear to be present when running Eclipse in a BiDi locale (get BiDi fragments then run Eclipse with program argument -nl ar_EG). The following 2 items need to be checked: 1. Paths to icons/images that can appear flipped must be prefixed with $nl$/ (e.g. $nl$/ICON_PATH) - this includes paths to icons and images in plugin.xml. 2. Must use Platform.find(Bundle, Path) to create the URL that is used to create the image descriptor. See Tod's Eclipse blog entry for more details on the code changes required. http://todcreaseyeclipse.blogspot.com/ NOTE: Only icons that have the possibility of being flipped need to have this prefix added - you can leave the paths of other icons as they are for 3.1.1 if you want to keep changes to a minimum. You can get the BiDi nl fragments from Cam-Thu Le so that you can see which of your icons have a reversed counterpart in BiDi locales. The following plugins of this component have been identified as requiring this check: *org.eclipse.help.ui Questions about this issue can be directed to Karice McIntyre or Tod Creasey.
I have fixed org.eclipse.help.ui. FYI: Another of help plug-ins - org.eclipse.help.webapp has been satisfactory BIDI enabled in 3.0 release. Since it is HTML, there is number of IFs in the code to handle RTL. Back and forward icons are switched using the code. Synchronize icon (that looks OK in either direction) is not flipped. Assuming fragments are installed when RTL layout is enabled, the approach of not doing icon switching with the code, but through fragments is recommended. It would allow for the synchronize icon to be flipped too. This is what we use for strings, but the icons that belong to the webapp are not loaded using our servlet that could be fixed in one line to account for fragments. I think this is a too risky change for 3.1.1, with no big benefit, and no one pointed any issue with org.eclipse.help.webapp plug-in. We can revisit the approach for 3.2, to enable icons to be substituted in fragments.
verified on eclipse-SDK-M20050923-1430-win32.zip with the following IES NL fragments: NLpack1_FeatureOverlay-eclipse-SDK-M20050923-1430.zip NLpack1-eclipse-SDK-M20050923-1430-win32.zip NLpack2_FeatureOverlay-eclipse-SDK-M20050923-1430.zip NLpack2-eclipse-SDK-M20050923-1430-win32.zip NLpackBidi_FeatureOverlay-eclipse-SDK-M20050923-1430.zip NLpackBidi-eclipse-SDK-M20050923-1430-win32.zip
