Bug 209891

Summary: Build Test failures
Product: [WebTools] WTP Java EE Tools Reporter: Chuck Bridgham <cbridgha>
Component: jst.j2eeAssignee: Carl Anderson <ccc>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc, david_williams
Version: 2.0.1Keywords: contributed
Target Milestone: 3.0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 213985    
Attachments:
Description Flags
path to remove test from 3.0
none
patch to remove test from 3.0
none
patch to add test back to performance bucket bjorn.freeman-benson: iplog+

Description Chuck Bridgham CLA 2007-11-14 21:34:39 EST
The test HeaderParserTests.testSpeed() tests the parse time deviation.  We need to remove this test, or relax the assert test, because under heavy server load, this test can fail.
Comment 1 David Williams CLA 2007-11-14 22:36:23 EST
I'd recommend it be removed. I fear it'd have to be loosened so much that it wouldn't mean much. 

Remember that the build machine is used by hundreds of other processes, so it wouldn't be unusual to get "swapped out" for unpredictably long periods at unpredictable times. 

If/when we get the performance tests running again, it could go in there, because one condition of running the performance test is having a dedicated machine, so it's always it a known state ... well, a little more predictable at least. 
Comment 2 Carl Anderson CLA 2007-11-15 09:38:30 EST
This test needs to be pulled from both 2.0.2 and 3.0 and moved to the performance bucket.
Comment 3 Ian Tewksbury CLA 2007-11-15 16:57:18 EST
Created attachment 83006 [details]
path to remove test from 3.0

This patch removes the test from HeaderPareserTests for the 3.0 stream.

Another patch to follow to add the test back in in the performance bucket.
Comment 4 Ian Tewksbury CLA 2007-11-15 17:34:44 EST
Created attachment 83009 [details]
patch to remove test from 3.0

Sorry, forgot to organize the imports on HeaderParserTests before creating patch.
Comment 5 Ian Tewksbury CLA 2007-11-15 17:36:41 EST
Created attachment 83010 [details]
patch to add test back to performance bucket

This patch adds the test back in the performance bucket.  Need to wait for Bug 208809 to be committed before test can be hooked up to performance test suite.
Comment 6 Carl Anderson CLA 2008-01-18 17:21:28 EST
Comment on attachment 83009 [details]
patch to remove test from 3.0

I committed this patch (since the test has recently begun failing on 3.0)
Comment 7 Carl Anderson CLA 2008-02-13 16:23:03 EST
Committed patch to add the test to the performance bucket to HEAD
Comment 8 David Williams CLA 2008-04-24 00:43:34 EDT
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.