Bug 124039

Comment 1 Michael Valenta 2006-03-30 09:14:23 EST

We just ran put of time on this so it will have to wait until 3.3.

Comment 2 Michael Valenta 2006-08-17 10:49:58 EDT

We do not plan on addressing this issue in 3.3.

Comment 3 Szymon Brandys 2009-06-04 06:17:22 EDT

*** Bug 271135 has been marked as a duplicate of this bug. ***

Comment 4 Szymon Brandys 2009-06-04 06:20:49 EDT

I'm pasting the comment from bug 271135:

The [Commit Files] dialog currently shows the resources been committed to the
repository, not the model objects.

The main point here is to avoid confusion to users that are not aware of
resources.

An initial step could be use Progressive Disclosure to initially hide the
resources from users.  The dialog would show with the bottom part collapsed as
default.  The dialog would have a "More >>" button where an advanced user would
click to expand the bottom part with the resources.

Comment 5 Neale Upstone 2009-09-03 08:37:52 EDT

I've just spotted this, along with several other CVS improvements on the 3.6 plan.

Is this improvement CVS-specific, or will all Team users get to benefit (i.e. SVN, Git, Bazaar)?

If it (and it's chums are CVS-specific) then I'd suggest that the time could be better spent on having eGit as part of Platform :)

Comment 6 Tomasz Zarna 2009-09-24 08:33:30 EDT

Created attachment 147999 [details]
Fix v01

First version of the patch. Not ready to commit. Requires an objective review and testing. I will do it next week.

Comment 7 Tomasz Zarna 2009-09-24 08:33:49 EDT

Created attachment 148000 [details]
mylyn/context/zip

Comment 8 Tomasz Zarna 2009-09-29 09:08:06 EDT

Although it's not a real blocker I would like to have bug 290505 fixed first.

Comment 9 Tomasz Zarna 2009-10-01 11:18:11 EDT

Created attachment 148539 [details]
Fix v02

Updated version, still a working copy.

Comment 10 Tomasz Zarna 2009-10-06 10:58:51 EDT

Created attachment 148896 [details]
Fix v03

Patch that is pretty close to be considered as "ready to apply". The only two remaining issues I'm aware of are:
* bug 291492
* when we want to commit a file with a conflicting change, then switch to a model to which the file doesn't belong, the Finish button stays disabled and error message is still informs about the conflict

Comment 11 Tomasz Zarna 2009-10-07 09:40:24 EDT

> * when we want to commit a file with a conflicting change, then switch to a
> model to which the file doesn't belong, the Finish button stays disabled and
> error message is still informs about the conflict

Filed bug 291600 for it, but I'm not sure if this is a real bug (see bug 291600, comment 1).

Comment 12 Tomasz Zarna 2009-10-07 10:00:00 EDT

Created attachment 148993 [details]
Fix v04

Code cleanup.

Comment 13 Tomasz Zarna 2009-10-07 10:09:07 EDT

Fix v04 applied to HEAD, available in builds >N20091006-2011.

Comment 14 Tomasz Zarna 2009-10-08 04:00:08 EDT

Filed bug 291616 for extra actions in context menu when in Change Sets model.