Bug 291616 - [Wizards] Commit dialog in Change Sets mode has to many context menu actions
Summary: [Wizards] Commit dialog in Change Sets mode has to many context menu actions
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-07 10:36 EDT by Tomasz Zarna CLA
Modified: 2009-10-26 12:10 EDT (History)
0 users

See Also:

Attachments
Fix v01 (2.06 KB, patch)
2009-10-22 11:18 EDT, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (152.27 KB, application/octet-stream)
2009-10-22 11:18 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2009-10-07 10:36:46 EDT 
HEAD

Actions for manipulating Change Sets (reassigning changes, making them unassigned and so on) should not be available in change tree's context menu. The menu should contain only actions for expanding, removing and adding a selected node to .cvsignore file as in old-style commit dialog (prior bug 124039).
Comment 1 Tomasz Zarna CLA 2009-10-21 08:48:15 EDT 
Let's try squeeze in this one for 3.6M3.
Comment 2 Tomasz Zarna CLA 2009-10-22 11:18:44 EDT 
Created attachment 150258 [details]
Fix v01

Fix work fine, however overriding ChangeSetCapability#enableActiveChangeSetsFor(ISynchronizePageConfiguration) to return always false worries me a little bit. The method is consulted by fillContextMenu(IMenuManager) in ChangeSetActionProvider and ChangeSetActionGroup. Returning false prevents change sets actions to appear. But the method is also called by ChangeSetModelProvider and ChangeSetModelManager. As long as it's used to check whether a context menu action should be added or enabled we're fine, we won't be displaying any change set actions at all. The other calls made in ChangeSetModelProvider need to be checked though.
Comment 3 Tomasz Zarna CLA 2009-10-22 11:18:51 EDT 
Created attachment 150259 [details]
mylyn/context/zip
Comment 4 Tomasz Zarna CLA 2009-10-26 12:10:30 EDT 
Fixed in HEAD, available in build I20091026-1300 and later.