Bug 290505 - [Wizards] Show content changes in CVS Commit wizard using a compare viewer
Summary: [Wizards] Show content changes in CVS Commit wizard using a compare viewer
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 124039
  Show dependency tree
 
Reported: 2009-09-25 06:42 EDT by Tomasz Zarna CLA
Modified: 2009-09-29 11:02 EDT (History)
0 users

See Also:

Attachments
Fix v01 (11.69 KB, patch)
2009-09-25 09:22 EDT, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (198.08 KB, application/octet-stream)
2009-09-25 09:22 EDT, Tomasz Zarna CLA 		no flags Details
Fix v02 (11.71 KB, patch)
2009-09-28 09:54 EDT, Tomasz Zarna CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2009-09-25 06:42:56 EDT 
I20090922-0800

Showing diffs in CVS Commit dialog has been added in bug 166333. As stated in bug 166333, comment 3, using a compare viewer could make the dialog a little bit to busy, mainly because content changes are displayed below the files. The patch for bug 166333 solves this issue by adding a pane for displaying diffs to the right of the comment and files. This is fine, but missing couple of things we could get for free when using a compare viewer:
* structure compare panes
* switching content viewers (e.g. from Java Source Compare to Text Compare)
* labels for compare participants: left, right, ancestor
* less code

This enhancement is about to make this happen, i.e. use a compare viewer to display both the files and content changes, but keep the layout we currently have in the dialog (diffs on the right-hand side). This would probably require some (API?) changes in CompareEditorInput, because CompareEditorInput.createContents(Composite) even though it can be overridden gives little space for layout changes.
Comment 1 Tomasz Zarna CLA 2009-09-25 09:22:31 EDT 
Created attachment 148112 [details]
Fix v01

Still need to figure out how to add title to the files pane, it should say "Changes". Other than that looks and works the same, but I will test it more next week.
Comment 2 Tomasz Zarna CLA 2009-09-25 09:22:40 EDT 
Created attachment 148113 [details]
mylyn/context/zip
Comment 3 Tomasz Zarna CLA 2009-09-28 09:54:26 EDT 
Created attachment 148236 [details]
Fix v02

Missing "Changes" title issue fixed.
Comment 4 Tomasz Zarna CLA 2009-09-29 11:02:06 EDT 
Released to HEAD, but filed bug 290506 and bug 290811 in the meantime. Added two API filters for CommitWizardCommitPage at the same time. Available in builds >N20090928-2000.