Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[smarthome-dev] Accept merge request using squash

Hello,

if we accept a pull request using the Github "merge & squash" feature,
Github create one commit message that contains all the messages of the
contained commits.

This results into a message that could contain multiple Signed-off-by entries.
If we don't change it manually on the Web frontend this looks like
e.g. this one: https://github.com/eclipse/smarthome/commit/9fe6be05a4dcc59117a9595bb888b7a1522290b4

Do we care about?
Should we all the time edit the commit message so?
For the given example above changing:

===
* removed getKey() method as it isn't needed anymore after introducing
the Identifiable interface

Signed-off-by: Kai Kreuzer <kai@xxxxxxxxxxx>

* fixed groovy tests

Signed-off-by: Kai Kreuzer <kai@xxxxxxxxxxx>
===

to

===

* removed getKey() method as it isn't needed anymore after introducing
the Identifiable interface
* fixed groovy tests

Signed-off-by: Kai Kreuzer <kai@xxxxxxxxxxx>
===

or sometimes we could the second message at all (for the example
perhaps because fixing the test should be done in the first commit).

So, should the committer edit the commit message all the time if it is "useful"?

Best regards,
Markus


Back to the top