Re: [recommenders-dev] [snipedior] Maven build

[Fabian Steeg <fsteeg@xxxxxxxxx>]

Hi Andreas!

The src-gen/ files of the UI module were already generated as part of the original build setup, see [1]. The problem you described with the sources not being found by the UI module build was due to a missing entry in the build.properties:

https://github.com/sewe/SnipEditor_MavenBuild/pull/1

I've also updated the Travis config to run the recommenders build. The SnipEditor build now fails in the feature module, which seems to be caused by the additional checks of the recommenders parent that you mentioned, see [2].

I've had some weird errors (in the the UI and the test modules) when building locally while the projects were also open in Eclipse, so try to close the projects or quit Eclipse when you have issues while running the build.

Cheers,
Fabian

[1] https://github.com/fsteeg/SnipEditor_MavenBuild/tree/9f30707eb130da9348b98eb3f51a3fce44a559f5
[2] https://travis-ci.org/fsteeg/SnipEditor_MavenBuild/builds/9391677

On 21.07.2013, at 20:23, Andreas Sewe <andreas.sewe@xxxxxxxxxxxxxx> wrote:

> Hi all (although probably only Stefan and Fabian are interested in this),
> 
> I just spend a couple of hours to bring the existing Maven build of
> Stefan's SnipEditor plugin in line with the org.eclipse.recommenders
> build. Essentially, the idea is to let all of Stefan's projects inherit
> from the respective parent POM on the o.e.r side (where there is one
> parent POM for plugins, one for tests, one for features, etc.).
> 
> Unfortunately, this turned out to be a bit more complicated than I had
> hoped for, due to all the code generation involved. In particular, my
> conversion still fails in the org.eclipse.recommenders.snipeditor.ui plugin:
> 
> org.eclipse.recommenders.snipeditor.ui.contentassist.AbstractSnipDSLProposalProvider
> cannot be resolved to a type.
> 
> This type exists in the src-gen folder of the plugin. However, that
> directory doesn't seem to be generated by the build (and I removed it
> from my conversion, as generated sources IMHO shouldn't be checked in).
> 
> Anyway, you can find my current conversion at [2]. First, build the
> mainline o.e.r [3] to install all its parent POMs into the local Maven
> repo. Then, run (in the root directory)
> 
>  mvn clean install -Dlicense.failIfMissing=false
> 
> to build it. BTW, the -Dlicense.failIfMissing is necessary as the files
> don't include proper license header yet; this is exactly why I want to
> inherit from the o.e.r parent POMs, to inherit all its checks and
> ultimately make merging of SnipEditor into the mainline easier.
> 
> So, I am afraid to make the conversion fully work some changes to the
> GenerateSnipDSL.mwe2 are in order, as it refers to various resources in
> its own project and *outside* its own project. This should IMHO be
> rectified insofar this is possible.
> 
> Ideally, the build would do the following things:
> 
> 1.) Place generated sources below target/generated-sources/xtend or
> target/generated-sources/mwe2 (following the Maven convention; this
> makes it unnecessary to reconfigure the maven-clean-plugin).
> 
> 2.) Write only in is own project structure, not in another project's.
> 
> Fabian, can you help me out here?
> 
> Best wishes,
> 
> Andreas
> 
> [1] <https://github.com/stefanprisca/SnipEditor_MavenBuild>
> [2] <https://github.com/sewe/SnipEditor_MavenBuild>
> [3]
> <http://git.eclipse.org/gitroot/recommenders/org.eclipse.recommenders.git>
> -- 
> Codetrails UG (haftungsbeschränkt)
> The knowledge transfer company
> 
> Robert-Bosch-Str. 7, 64293 Darmstadt
> Mobile: +49-170-811-3791
> http://www.codetrails.com/
> 
> Managing Director: Dr. Marcel Bruch
> Handelsregister: Darmstadt HRB 91940
> _______________________________________________
> recommenders-dev mailing list
> recommenders-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/recommenders-dev