Re: [leshan-dev] Commit policy: RTC or CTR?

[Julien Vermillard <jvermillard@xxxxxxxxx>]

I'm for trusting commiter judgement rather than metrics, anyway if someone see something too large on the commit list, don't hesitate to say so.

On Thu, Mar 12, 2015 at 6:27 PM J.F. Schloman <john.schloman@xxxxxxxxx> wrote:

I'm good with going with the flow with CTR :)  I guess is there a metric we would want to use for PRs?  Like > 1000 line changes (or something more flexible)?

-JF

On Thu, Mar 12, 2015 at 9:38 AM, Kai <sophokles.kh@xxxxxxxxx> wrote:

+1 for CTR and PRs when appropriate.

On Thu, Mar 12, 2015 at 2:41 PM Manu Sangoi <manu.sangoi.dev@xxxxxxxxx> wrote:

Hi, 

I'm fine with CTR too. And pull-requests when needed only.

Manu

2015-03-12 14:03 GMT+01:00 Julien Vermillard <jvermillard@xxxxxxxxx>:

Hi,

Since the repository is up, I think it's time to discuss about commit policy (for committers).

I think basically we have two choice:

RTC: Review-Then-Commit

We don't commit directly in the master we create a pull request and ask peer to review it, if everything fine we can merge it.

CTR : Commit-Then-Review

Any committer can commit directly in master, all the committer need to follow the commit mailing list (https://dev.eclipse.org/mhonarc/lists/leshan-commit/) and review the commit afterward.

If something is wrong, just mention it on the mailing list and the author will need to revert, fix or explain why he think it's a good idea.

I'm more in favor in CTR, creating a pull-request for any minor change can by a PITA, but we are still free to use pull-request when we think reviewing before committing can be useful (like massive Simon's refactoring :).

WDYT ?

Julien

_______________________________________________
leshan-dev mailing list
leshan-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/leshan-dev

_______________________________________________
leshan-dev mailing list
leshan-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/leshan-dev

_______________________________________________
leshan-dev mailing list
leshan-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/leshan-dev

_______________________________________________
leshan-dev mailing list
leshan-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/leshan-dev