Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ease-dev] Concerning Bug 511528

Hi,

 

sorry, I do not understand the problem. For the project tree, the relative information you may retrieve would be sufficient. If you compare the raw link and the ‘prettyPrint’one, both contain the root folder “_javascript_%20Beginner%20Tutorial”, if you detect it in the raw link and take the part to the right of it:

/99%20Others/02%20Title%20Clock.js

 

You should be able to decode the correct tree structure from it.

 

Maybe I do not understand the problem correctly, as mentioned in the beginning. I would suggest, simply come up with a commit where we can see the problem, then we can work on it.

 

Best regards

Christian

 

From: ease-dev-bounces@xxxxxxxxxxx [mailto:ease-dev-bounces@xxxxxxxxxxx] On Behalf Of Utsav Oza
Sent: Sunday, June 04, 2017 3:04 PM
To: ease developer discussions
Subject: Re: [ease-dev] Concerning Bug 511528

 

I agree to not use raw content urls for registering the location in the preferences. However, the concern here is that after we parse the location for scripts, we call updateLocation() using IRepositoryService instance in which we pass the obtained scriptURI to fetch keywords from the script. So there remains no other option other than to pass raw content url to the method. The problem I am facing is that the project tree in the script explorer is constructed from the same raw content url which is somewhat inaccurate. Should we consider an option to alter this behavior, if not what other way would rectify this problem ?

 

On Sat, May 13, 2017 at 12:46 PM, Christian Pontesegger <christian.pontesegger@xxxxxx> wrote:

Hi,

the long value to detect file changes originates is timestamps from the local file system. We could change the datatype to String, allowing to store an indicator. Then whenever that inidcator does not match we have to update the script location.

For registering I would rather use an address like this:
https://github.com/utsavoza/sample-scripts/tree/master/_javascript_%20Beginner%20Tutorial

From there we need to construct raw urls and API calls to retrieve the file structure and folder hierarchy.

Christian

 

On 12.05.2017 16:10, Utsav Oza wrote:

Hello,

For Bug 511528 - Create location parser for github, I have created a parser class that parses github repositories for scripts. The class currently updates script location using the raw content url (eg: https://raw.githubusercontent.com/utsavoza/sample-scripts/master/_javascript_%20Beginner%20Tutorial/99%20Others/02%20Title%20Clock.js) and current timestamp. The issue here is that repository hierarchy is constructed from the raw content url which is not similar to the actual project hierarchy (See attached screenshot). Additionally, the aim is to use sha hashes (String value) to identify and compare with the latest scripts however, the updateLocation takes the input as long values. I suppose we need to provide another way to resolve remote locations uri ? I am uncertain about how to make use of sha values as timestamp for scripts.

Utsav Oza

 

_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev

 


_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev

 

Attachment: smime.p7s
Description: S/MIME cryptographic signature


Back to the top