[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[wtp-incubator-dev] Re: How to submit contributions???
|
If you find stuff like the Implementing Serializable but doesn't have an
id. Fix them.
Basically anything that the Find Bugs report generated during the
builds, should be fixed.
https://build.eclipse.org/hudson/view/WTP/job/cbi-wtp-inc.vex/
Holger Voorman is the main person working on VEX at the moment, so I've
copied him on this email as well. He can provide some more
information. Also, these type of VEX development emails should be on
the WTP Incubator mailing list, so I've copied that list as well.
Dave
Florian Thienel wrote:
Done: https://bugs.eclipse.org/bugs/show_bug.cgi?id=302680
And WOW! It was committed only after 2 hours. That IS motivating.
I'm on my way through other packages to eliminate more warnings. I saw
that there are project specific settings for compiler warnings/errors.
Do you have any special settings that differ from the default settings
of the PDE?
Besides the typical generics-problems I came across some internal
classes that implement Serializable without a serialVersionUid. What
is the preferred way to handle this? (create a serialVersionUid or add
@SuppressWarning annotation)
Florian
Am 11.02.2010 23:39, schrieb David Carver:
Great.
If you could please open a bug and attach the patch there.
https://bugs.eclipse.org/bugs/enter_bug.cgi?product=WTP%20Incubator
All patches and contributions need to be attached to a corresponding
bug.
Thanks.
Dave
On 02/11/2010 02:12 PM, Florian Thienel wrote:
Hello Dave!
I decided to put some time and love into VEX. To dive into the code
base, I started by doing some refactorings to get rid of the warnings
in ListernerList.
Now that I've finished a first tiny piece of work I come to the
question how to submit such contributions?
I attached a patch with my changes including a small unit test for
ListenerList.
Best regards,
Florian
