Re: AW: [smila-dev] Refactored bundle org.eclipse.smila.xmlstorage

["Marius Cimpean" <marius.cimpean@xxxxxxxxxxx>]

Hi,

I will take care of this.

Best Regards,
Marius

----- Original Message ----- 
From: <dhazin@xxxxxxxxxxxx>
To: "Smila project developer mailing list" <smila-dev@xxxxxxxxxxx>
Sent: Wednesday, November 12, 2008 11:41 AM
Subject: Re: AW: [smila-dev] Refactored bundle org.eclipse.smila.xmlstorage


Hi,

2) Indeed, I've added this helper many time ago when xmlstorage API was
only discussed; I've added TODO to replace it with XssConnection method
when it will be ready to blackboard, but not to the helper. So I think
this method should be added to XssConnection interface and replace that
helper.

Thanks,
Dmitry

> Thanks Marius,
>
> 1) I fixed this. Don't know why it was not deleted when I committed my
> changes.
>
> 2) You may be right. I leave this to be decided by Tom. My goal was only
> to separate existing API from implementation, not doing any API
> refactoring. So please discuss this (as well as the architecture ideas you
> suggested  yesterday) with Tom.
>
> Bye,
> Daniel
>
>
> > -----Ursprüngliche Nachricht-----
> > Von: smila-dev-bounces@xxxxxxxxxxx [mailto:smila-dev-
> > bounces@xxxxxxxxxxx] Im Auftrag von Marius Cimpean
> > Gesendet: Dienstag, 11. November 2008 14:08
> > An: Smila project developer mailing list
> > Betreff: Re: [smila-dev] Refactored bundle org.eclipse.smila.xmlstorage
> >
> > Hi Daniel,
> >
> > The new xml storage bundles look fine. There are just two small remarks
> > I
> > would add:
> > 1.  org.eclipse.smila.xmlstorage bundle still contains empty packages
> > which
> > are no longer needed (so, they just need to be removed)
> > 2. since the org.eclipse.smila.xmlstorage bundle represents the service
> > interface, I would say this bundle should not contain any helper or
> > util
> > class (like XssConnectionHelpe ). Also, this helper class should not
> > depend
> > on the concrete implementation of the XssConnection (which is passed as
> > input parameter in XssConnectionHelpe.addOrUpdateDocument.....). ...so
> > even
> > the org.eclipse.smila.xmlstorage.bdb is not the perfect place for this
> > class.
> > Anyway, I suggest the correct solution would be adding/implementing of
> > the
> > addOrUpdateDocument method in the XssConnection interface (and its
> > implementation) and removing the helper class, so the Blackboard
> > service
> > only uses the XssConnection (there is also a TODO in the
> > BlackboardServiceImpl class related to this)..... this could also be
> > treated
> > as different task.
> >
> > Best Regards,
> > Marius
> >
> > ----- Original Message -----
> > From: <Daniel.Stucky@xxxxxxxxxxx>
> > To: <smila-dev@xxxxxxxxxxx>
> > Sent: Tuesday, November 11, 2008 1:26 PM
> > Subject: [smila-dev] Refactored bundle org.eclipse.smila.xmlstorage
> >
> >
> > Hi all,
> >
> > I refactored bundle org.eclipse.smila.xmlstorage and split it into two
> > bundles, containing the interface and the Berkely implementation:
> > - org.eclipse.smila.xmlstorage
> > - org.eclipse.smila.xmlstorage.bdb
> >
> >
> > @ Tom + Marius:
> > SMILA runs and the xmlstorage tests succeeded. Even so I'd like to ask
> > you to briefly review my changes.
> >
> > Bye,
> > Daniel
> > _______________________________________________
> > smila-dev mailing list
> > smila-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/smila-dev
> >
> >
> >
> > _______________________________________________
> > smila-dev mailing list
> > smila-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/smila-dev
> _______________________________________________
> smila-dev mailing list
> smila-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/smila-dev


_______________________________________________
smila-dev mailing list
smila-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/smila-dev