Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
AW: [riena-dev] Time for ITreeRidget.bindToModel() refactoring?

Hi Elias,

I have annoyed this also (checkstyle warning).
I think your idea with the TreeRidgetBinder is much better than the existing variants of bindToModel.

Greetings

Thorsten


-----Ursprüngliche Nachricht-----
Von: riena-dev-bounces@xxxxxxxxxxx [mailto:riena-dev-bounces@xxxxxxxxxxx] Im Auftrag von Elias Volanakis
Gesendet: Montag, 29. März 2010 20:47
An: Riena Developers list
Betreff: [riena-dev] Time for ITreeRidget.bindToModel() refactoring?

"If you methods have more than 7 parameters, you probably forgot a few
already" (anonymous)

I'm not sure if we should change this, but I'm a bit scared by the
growing bindToModel(...) methods in ITreeRidget. We now have 5
variants. The latest addition has 10 parameters.

Maybe it's time to introduce bindToModel(TreeRidgetBinder
helperObject) and potentially remove some of the more recent
bindToModel(...) variants.

Having a helperObject also means we can add additional parameters
without having to add bindToModel(...) methods (=API breakage).

Food for discussion,
Elias.

--
Elias Volanakis | Technical Lead | http://eclipsesource.com
elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 | @evolanakis
_______________________________________________
riena-dev mailing list
riena-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/riena-dev

-------------------------------------------------------------
compeople AG
Untermainanlage 8
60329 Frankfurt/Main
fon: 069 / 27 22 18 0
fax: 069 / 27 22 18 22
web: www.compeople.de
Vorstand: Jürgen Wiesmaier
Aufsichtsratsvorsitzender: Christian Glanz
Sitz der Gesellschaft: Frankfurt/Main
Handelsregister Frankfurt HRB 56759
Ust-Ident.-Nr: DE207665352
-------------------------------------------------------------



Back to the top