Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rdf4j-dev] Correctly signing a commit

Hi Bart, Håvard,

Thanks, I had been doing the work to get the -S (uppercase) to work!
My dyslexia strikes again :(

Regards,
Jerven
On 2019-02-12 18:26, Bart Hanssens (BOSA) wrote:
Yeah, the -s (lowercase, not to be confused with uppercase -S for
digitally signing) is probably to blame.
 Perhaps it can be fixed by ammending the last commit like:

 git commit --ammend -s

 Sorry for the red tape, but Eclipse is fairly strict about this (and
probably for good reasons)

 Best regards

 Bart

-------------------------

FROM: rdf4j-dev-bounces@xxxxxxxxxxx <rdf4j-dev-bounces@xxxxxxxxxxx> on
behalf of Håvard M. Ottestad <hmottestad@xxxxxxxxx>
SENT: Tuesday, February 12, 2019 18:13
TO: Jerven.Bolleman@sib.swiss; rdf4j developer discussions
SUBJECT: Re: [rdf4j-dev] Correctly signing a commit

One thing that I see is that the commit is not signed-off. That’s
just fancy git for: your commit message should be followed by a blank
line and “Signed-off-by: Your Name <your.name@xxxxxxxxx>”.

This is what one of my commits looks like:
—

eclipse/rdf4j#1111 started adding code to support sh:class, plus som
tests for EqualsJoin that should have been made a while ago.

Signed-off-by: Håvard Ottestad <hmottestad@xxxxxxxxx>
—

When you commit you can add “- s” to your git command and it’ll
happen automatically.

You also have to digitally sign some stuff over at eclipse, since this
is an eclipse project. Jeen has some nice documentation for that here:
https://github.com/eclipse/rdf4j/blob/master/.github/CONTRIBUTING.md

Håvard

On 12 Feb 2019, at 16:57, Jerven Tjalling Bolleman
<Jerven.Bolleman@sib.swiss> wrote:

Hi All,

I am trying to do the right thing for the eclipse IP check.

https://github.com/eclipse/rdf4j-storage/pull/171

I got to the state that it is a verified github commit.
However, the test IP check test is still red.
I have the feeling I am missing something obvious :(
Does anyone have an idea of what it is?

Also apologies for the force pushes I did trying to fix it myself.

Regards,
Jerven

--
Jerven Tjalling Bolleman
SIB | Swiss Institute of Bioinformatics
CMU - 1, rue Michel Servet - 1211 Geneva 4
t: +41 22 379 58 85 - f: +41 22 379 58 58
Jerven.Bolleman@sib.swiss - http://www.sib.swiss [1]

_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/rdf4j-dev


Links:
------
[1] http://www.sib.swiss

--
Jerven Tjalling Bolleman
SIB | Swiss Institute of Bioinformatics
CMU - 1, rue Michel Servet - 1211 Geneva 4
t: +41 22 379 58 85 - f: +41 22 379 58 58
Jerven.Bolleman@sib.swiss - http://www.sib.swiss



Back to the top