Yeah, the -s (lowercase, not to be confused with uppercase -S for digitally signing) is probably to blame.
Perhaps it can be fixed by ammending the last commit like:
git commit --ammend -s
Sorry for the red tape, but Eclipse is fairly strict about this (and probably for good reasons)
Best regards
Bart
From: rdf4j-dev-bounces@xxxxxxxxxxx <rdf4j-dev-bounces@xxxxxxxxxxx> on behalf of Håvard M. Ottestad <hmottestad@xxxxxxxxx>
Sent: Tuesday, February 12, 2019 18:13
To: Jerven.Bolleman@sib.swiss; rdf4j developer discussions
Subject: Re: [rdf4j-dev] Correctly signing a commit
One thing that I see is that the commit is not signed-off. That’s just fancy git for: your commit message should be followed by a blank line and “Signed-off-by: Your Name < your.name@xxxxxxxxx>”.
This is what one of my commits looks like:
—
eclipse/rdf4j#1111 started adding code to support sh:class, plus som tests for EqualsJoin that should have been made a while ago.
Signed-off-by: Håvard Ottestad <hmottestad@xxxxxxxxx>
—
When you commit you can add “- s” to your git command and it’ll happen automatically.
|