Re: [rdf4j-dev] Correctly signing a commit

["Håvard M. Ottestad" <hmottestad@xxxxxxxxx>]

One thing that I see is that the commit is not signed-off. That’s just fancy git for: your commit message should be followed by a blank line and “Signed-off-by: Your Name <your.name@xxxxxxxxx>”.

This is what one of my commits looks like:

—

eclipse/rdf4j#1111 started adding code to support sh:class, plus som tests for EqualsJoin that should have been made a while ago.

Signed-off-by: Håvard Ottestad <hmottestad@xxxxxxxxx>

—

When you commit you can add “- s” to your git command and it’ll happen automatically.

You also have to digitally sign some stuff over at eclipse, since this is an eclipse project. Jeen has some nice documentation for that here: https://github.com/eclipse/rdf4j/blob/master/.github/CONTRIBUTING.md

Håvard

On 12 Feb 2019, at 16:57, Jerven Tjalling Bolleman <Jerven.Bolleman@sib.swiss> wrote:

Hi All,

I am trying to do the right thing for the eclipse IP check.

https://github.com/eclipse/rdf4j-storage/pull/171

I got to the state that it is a verified github commit.
However, the test IP check test is still red.
I have the feeling I am missing something obvious :(
Does anyone have an idea of what it is?

Also apologies for the force pushes I did trying to fix it myself.

Regards,
Jerven

--
Jerven Tjalling Bolleman
SIB | Swiss Institute of Bioinformatics
CMU - 1, rue Michel Servet - 1211 Geneva 4
t: +41 22 379 58 85 - f: +41 22 379 58 58
Jerven.Bolleman@sib.swiss - http://www.sib.swiss

_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/rdf4j-dev