| Re: [ptp-dev] Question about the ETFw PerformanceAnalysisTab |
Wyatt,
I added you as a reviewer to the patch, but I haven't seen any activity from you so I'm not sure if you are receiving emails from Gerrit. When you get a chance, can you take a look at the the change set at: https://git.eclipse.org/r/20892 and let me know if you have issues or see anything that should be re-worked?
Thanks,
Chris
On 01/15/2014 10:57 AM, Wyatt Spear wrote:
I have access to a UO cluster where I can do remote testing. I'll check it out when I get access to the patch.Thanks,Wyatt
On Wed, Jan 15, 2014 at 8:06 AM, Christopher Navarro <cmnavarr@xxxxxxxxxxxx> wrote:
Greg,
If this isn't a high priority for what you're working on, this will probably be addressed very soon with my current ETFw work. Part of my refactoring with the PerformanceAnalysisTab/ETFWParentLaunchConfigurationTab removes my re-implementation of performApply inside ETFw's parent tab and is more in line with how the ResourcesTab saves attributes to the launch configuration. This removal of duplicated code should make ETFw UI more stable.
The current issue I'm running into and haven't yet tracked down is with etfw attributes not being found inside the LCVariableMap and the map creates new attributes. The launch config then has the wrong attribute info since the created attribute is very basic, unlike the attribute that was defined in the tool's xml. My problem might be related to yours. Perhaps I shouldn't be using the RMVariableMap from the controller, but create my own that is initialized on the control data from the etfw tool and base my LCVariableMap on my RM map. I will give it a try and see if it addresses both issues. I would like to get this into gerrit by Friday or early next week so you and Wyatt can review what I've done and test it. I'm also waiting to get access to XSEDE so I can test it remotely to make sure it doesn't just work locally.
Chris
On 01/15/2014 09:34 AM, Greg Watson wrote:
Chris,
I’m having a problem using org.eclipse.ptp.internal.etfw.launch.PerformanceAnalysisTab in my own launch configuration. When I switch from the Resources tab to the PerformanceAnalysisTab tab then back to the Resources tab, all the settings in the Resources tab are reset. I think this is occurring because you’re using the variable map from the ILanchController at line 240:
vmap = controller.getEnvironment();
If I replace this with:
vmap = new RMVariableMap();
then the problem goes away. I’m not sure why this is the case, but it appears that sometimes all the attributes in the map are reset.
Do you have any idea why this might be happening. Would you be ok with this change?
Thanks,
Greg
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev
_______________________________________________ ptp-dev mailing list ptp-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/ptp-dev
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev