[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [platform-ui-dev] Updating JFace version ID
|
I still have doubts we should add generics to the current jface library
because it will result in a tremendous amount of warnings many projects
will not be able to fix for a long time.
Wouldn't it be wiser to introduce a JFace2 which also would allow to
break the API and e.g. get away with
IStructuredContentProvider#getElements(Object inputElement) : Object[]
Please note I'm not proposing jface 4.0.0 because haveing 2 versions of
jface is a straight way to a disaster.
Tom
On 10.06.14 14:58, Markus Keller wrote:
> For Mars, it's totally fine to move org.eclipse.jface to 3.11 for
> non-breaking API changes like this.
> That's the normal evolution according to
> https://wiki.eclipse.org/index.php/Version_Numbering#When_to_change_the_minor_segment
>
>
> Markus
>
>
>
> From: Jeanderson <jeandersonbc@xxxxxxxxx>
> To: platform-ui-dev@xxxxxxxxxxx
> Date: 2014-06-10 03:00
> Subject: [platform-ui-dev] Updating JFace version ID
> Sent by: platform-ui-dev-bounces@xxxxxxxxxxx
> ------------------------------------------------------------------------
>
>
>
> Hi all,
>
> I'm currently working with Lars Vogel and Hendrik Still in our proposal
> to add Generics support to JFace viewers as part of Google Summer of
> Code 2014.
>
> I'm migrating old patches from last year by Hendrik to continue the work
> from where he stopped (first attempt to add Generics on GSoC 13).
>
> After merging the patch "_https://git.eclipse.org/r/#/c/16584/_";, we
> have the following change:
>
> ---------Before--------
> public class StructuredViewerInternals {
> ...
> protected static void setAssociateListener(StructuredViewer viewer,
> AssociateListener listener) { ... }
>
> protected static Widget[] getItems(StructuredViewer viewer, Object
> element) { ... }
> ...
> }
>
> ---------After-----------
> public class StructuredViewerInternals {
> ...
> protected static <E,I> void setAssociateListener(StructuredViewer<E,I>
> viewer,
> AssociateListener listener) {...}
>
> protected static <E,I> Widget[] getItems(StructuredViewer<E,I> viewer, E
> element) { ... }
> ...
> }
> -----------------------------
>
> Although tests run with no problems, Eclipse complains that this is a
> minor change (change of API with backwards compatibility), therefore
> should be 3.11.qualifier instead of 3.10.qualifier.
>
> I'm writing to know if there's any problem on updating the JFace
> version, so we won't have any problems when the whole work gets done and
> ready to be merged into Eclipse repository.
>
> I'm working in a forked branch at Github: jeandersonbc/eclipse.platform.ui
>
> Thanks in advance. I hope to get more involved with the community and
> continue to contribute to Eclipse after the program.
>
> Best regards,
> Jeanderson Barros Cândido
> _http://jeandersonbc.github.io_
> <http://jeandersonbc.github.io/>_______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>
>
>
> _______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>
