Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-dev] Review practice



On Thu, Mar 30, 2023 at 2:40 PM Sebastian Zarnekow <sebastian.zarnekow@xxxxxxxxx> wrote:
Hi there,

It might be my poor understanding of the current process, so I'm asking here on the mailing list:

Are reviews a prerequisite for stuff that's supposed to be merged into platform?

Unfortunately, we are not in a position to have such a prereq (although I would love this to be the case). Very few people do reviews and PRs stand in the queue (https://github.com/pulls?user=eclipse-platform) longer than acceptable thus the overall practice is that committers push things without review when feeling comfortable about the stability of the patch. Of course, this doesn't mean that things couldn't be done better or even that there wouldn't be issues - it just means that's the only way to make progress with current resources.
Help would be more than appreciated to review pending patches in the review queue, agree on what "timely" reply/review means and eventually raise the requirements.
 

Best
Sebastian
_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev


--
Aleksandar Kurtakov
Red Hat Eclipse Team

Back to the top