Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-dev] Review practice
  • From: "Hoepfner, Marcus" <marcus.hoepfner@xxxxxxx>
  • Date: Thu, 30 Mar 2023 11:57:53 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sap.com; dmarc=pass action=none header.from=sap.com; dkim=pass header.d=sap.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZH5CfjPlqX0WYtkiaLo8hSnHU8U+KIOyVJHrLJ4AnwU=; b=nNfzBhTk9Oc+2WCSpm3XAumpyl24I6dodUZcCPVoHzDQ/h29lmKTKVkc40PGbZkMwKkJTToAHw5EBJE8lU6uyXoJ03cXw/hMdyRxwPfkus914FVNrhuVhlYFIKJ4ZyBrMHrycLfVhk40eCq48hjlndbE+ZsMsSjYk6YQryP14zuylCbHf5RLqbg1mIv+aTAmSCKcUnvnyz0ieumUhCjqxOFBX6PkhBvv4O3w/dwi6QmXZQbyJH/rqb6NAEZqclSgZgPXh2UafFnhoZf+hIZyisHjbY8530cy4393jLGMjCxG/W0Cz5W1fY+Cq48g91N5AONgQsblLXiNmoFttlNqrg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nivhlh5VmyfSC9C5o0Qp9wGiVVv7ehPDbDmgB7InUltpUXtU7mD0Nr+EGgi5Yju1E42hKYDN10QNRq/lb4DvmCsdGpYgs/GbVNlG9Cm9LJVNVWAUhfXA4cKi2FaJk50P9dqKpY/glbjiX8SpurgNsawbIYmH2Vpyh1s/nrcY73Ikuy+Aak+d5l/FjvaUElmTbAQQVSFOPSho6lNCK0xdd6b2NH2iqOQSeFzn+Er5ljBO7ujUBEkJksp2nat7h14qcR9ZjAUJWQUFCiC613k25WQTxhpzc12571BCmyT3zeCPQZZF4pv4VOXzFISDzEqgFJJ/FHuKz0r5DCkp5ukuGA==
  • Delivered-to: platform-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/platform-dev/>
  • List-help: <mailto:platform-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/platform-dev>, <mailto:platform-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/platform-dev>, <mailto:platform-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHZYvxwFXOORiTFb0qV0ag3jlFAca8TNimAgAABEnk=
  • Thread-topic: [platform-dev] Review practice

Why are you asking? Did you see a concrete issue in particular?
I general I’d not commit without code review. I usually get helpful comments.
And even it is just about a typo in Javadoc, it is worth it.


A colleague once said, code review is kind of deferred pair programming. I like that, though it might not be 100% correct.

 

 

On Thu, Mar 30, 2023 at 1:40 PM Sebastian Zarnekow <sebastian.zarnekow@xxxxxxxxx> wrote:

Hi there,

 

It might be my poor understanding of the current process, so I'm asking here on the mailing list:

Are reviews a prerequisite for stuff that's supposed to be merged into platform?

 

A working build+test is usually a requirement. Peer reviews are not a prerequisite for committers, but it's still a good practice to get someone else to look at a patch before merging, even for committers. For non-committers, a review/approval from a committer is a requirement before a merge anyway.

HTH

Back to the top