[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [platform-core-dev] -1 for James Blackburnon eclipse.platform.coreby John Arthorne
|
> I understand that your decision Martin is caused by the fact
> that there are fixes that you or James want to squeeze in 3.6.
No, absolutely not!
Both James and I understand very well the importance of
stability, and he explicitly told me on his own account
that he'd want to wait for other committer's approval
before actually making changes to the code.
On all of the bugs where I asked, James commented that
he'd rather wait for 3.7 than push it in prematurely.
You'll see this in the comments on bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=306822
The proposal of making James a Committer is related to
the case that I recently reviewed some of his patches
and thought like "oh my, this should really have been
considered much earlier".
Why hadn't it been considered earlier? Because nobody
took the time reviewing even additions of Unittests
that would have been an asset at any rate. How can this
be improved? By adding more people to the team. People
like James, who have publicly shown diligence, understanding
and good judgement.
I understand John's arguing of waiting for more public
record (but note that John missed some very good
contributions, as well as the time span when these
contributions were originally made). Like Doug, I do
not understand the value of waiting per se.
Szymon, I really appreciate your offering direct contact
to get things reviewed early. But I think we'll be even
more effective if there's more committers that can
handle simple things themselves, such that you can
focus on the hard things. Quite frankly, I nominated
James because I see potential for him helping out with
things that I don't have time for in the longer run.
I'm not going to argue much more about this committer
nomination, and if people think we should really wait,
well, we can wait since there's more urgent things
to be done than arguing among ourselves. But I did
want to set our (my) motivation straight.
Martin
