[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [phoenix-dev] Banners First Look
|
I think that's a great improvement and I like the way the tabs become
less file folder-like.
+1 for solution #1. Also, I like Chris' idea about decreasing
Contact/Legal and increasing the other icons. The first thing I noticed
when I looked at the banner was the white cutout at the top with
legal/contact which isn't probably what we want to be the first thing
you notice?
Do we still have the opportunity to get changes made?
Karl
Chris Aniszczyk wrote:
> +1, it looks nice.
>
> I prefer the 1st approach.
>
> On a side note, I'm up for Contact/Legal being a bit smaller and increase
> the size of the "icons" representing the various pages (ie., live,planet
> etc...)
>
> ---
> Chris Aniszczyk | IBM Lotus | Eclipse Committer |
> http://mea-bloga.blogspot.com | +1.860.839.2465
>
>
>
> From: "Nathan Gervais" <nathan@xxxxxxxxxxx>
>
> To: <phoenix-dev@xxxxxxxxxxx>
>
> Date: 07/17/2007 03:06 PM
>
> Subject: [phoenix-dev] Banners First Look
>
>
>
>
>
>
> Phoenix Committers,
>
> We have received the final bits for the banners that we plan to deploy to
> our web properties. My first task is to fit this new header into our
> current Phoenix (www.eclipse.org) infrastructure.
>
> I’ve spent some time with the HTML / CSS that we have received. I’ll try
> to explain as best I can without making reference to the image I’ve
> attached. Since these changes affect eclipse.org-common so I’d like to
> solicit the feedback / votes from the other Phoenix committers on how to
> proceed with integration of this new banner.
>
>
> Old Layout
>
> Our old layout used a simple structure to build a page. It started off with
> a header, which contained our header graphic and search bar, then followed
> with a menu each in separate divs.
>
> <div id=”header”>
> some code
> <div id=”search”>search stuff</div>
> </div>
> <div id=”menu”>
> Some menu items
> </div>
>
> Accordingly our php logic for building the pages was simple. We include
> header.php and then menu.php. Simple linear includes.
>
> New Layout
>
> Our new layout is simple enough but the problem we encounter does not have
> a quick fix. I’ll go over the markup here to illustrate.
>
> <div id=”header”>
> <div id=”header-graphic”>eclipse logo graphic</div>
> <div id=”navigation”>this is the contact / legal and the 3 navigation
> icons that lead to our other sites</div>
>
> <div id=”menu”>some menu items</div>
> <div id=”search”>search stuff / rss feeds / font size toggle</div>
> </div>
>
> *See Figure1.jpg (attached) for a visual explanation of the issue.
>
> Every page in phoenix is generated by the $App->generatePage() function
> call. This function is fairly simple in that it includes the header.php
> and then the menu.php from the according Theme directory.
> Since the menu now appears inside the header we cannot call the menu after
> the header.php file has been included. Since then the <div id=”header”>
> would be closed before the menu would be included. This leads us to
> solution #1
>
> Solution #1
>
> This is my preferred solution to the issue.
> In header.php we would start the <div id=’header’> and have it create the
> logo / navigation divs. It would then end without closing the header div.
> In menu.php we would then create the menu / search bar and then close out
> the header div.
>
> I like this solution because it would only affect the phoenix skin and no
> others. It could lead to confusion if someone wanted to know how the skin
> works / looks.
>
> Solution #2
>
> In solution 2 we would scrap the menu.php from the phoenix skin. All of its
> content would then be placed into header.php.
> Inside app.class.php in the generatePage() function we could put some theme
> checking so that menu.php wouldn’t be called if the theme == “phoenix”.
>
> Nathan Gervais - nathan@xxxxxxxxxxx
> Web Developer
> The Eclipse Foundation
>
>
> (See attached file: Figure1.jpg)
> _______________________________________________
> phoenix-dev mailing list
> phoenix-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/phoenix-dev
>
>
> ------------------------------------------------------------------------
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> phoenix-dev mailing list
> phoenix-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/phoenix-dev
