Re: [pde-dev] PDE patches for Image Browser

["Vikas Chandra" <Vikas.Chandra@xxxxxxxxxx>]

Hi Alena,

We cant push anything till next Monday because of M3 freeze and testing. I plan to commit both of them
sometime next week. We can take up further discussion on the 2 bugs.

Regards,
Vikas
------------------------------------------------------------------------
Eclipse Modeling/ PDE
IBM Rational
EGL D Block - Bangalore, India
Office Phone No : +91 - 80 - 41776506
------------------------------------------------------------------------

Alena Laskavaia ---10/27/2015 07:48:45 AM---I submitted new patches. They are conflicting since they apply to the same file. If you ok with the

From: Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx>
To: Vikas Chandra/India/IBM@IBMIN
Cc: "Eclipse PDE general developers list." <pde-dev@xxxxxxxxxxx>
Date: 10/27/2015 07:48 AM
Subject: Re: [pde-dev] PDE patches for Image Browser
Sent by: laskava@xxxxxxxxx

---

I submitted new patches. They are conflicting since they apply to the same file. If  you ok with them please push Show more removal first and I will merge the second one.
https://git.eclipse.org/r/55603 Bug 441659: Image Browser does not advance on "Show more" (Remove it)

https://git.eclipse.org/r/55602 Bug 477016 - Image Browser: needs filter
       



On Mon, Oct 26, 2015 at 12:25 PM, Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx> wrote:

Thanks, I will try to address the comment as soon as possible


On Mon, Oct 26, 2015 at 2:04 AM, Vikas Chandra <Vikas.Chandra@xxxxxxxxxx> wrote:
Hi Alena,

I have already posted review comments for 2 of the patches you did for PDE.

I will move them out of 4.6M3 and then triage them for 4.6M4 as of now.

Regards,
Vikas
------------------------------------------------------------------------
Eclipse Modeling/ PDE
IBM Rational
EGL D Block - Bangalore, India
Office Phone No : +91 - 80 - 41776506
------------------------------------------------------------------------

Vikas Chandra---10/08/2015 10:43:28 AM---I will review this today. Thanks Alena !

From: Vikas Chandra/India/IBM
To: elaskavaia.cdt@xxxxxxxxx, "Eclipse PDE general developers list." <pde-dev@xxxxxxxxxxx>
Cc: pde-dev-bounces@xxxxxxxxxxx
Date: 10/08/2015 10:43 AM
Subject: Re: [pde-dev] PDE patches for Image Browser


---



I will review this today.

Thanks Alena !

Regards,
Vikas
------------------------------------------------------------------------
Eclipse Modeling/ PDE
IBM Rational
EGL D Block - Bangalore, India
Office Phone No : +91 - 80 - 41776506
------------------------------------------------------------------------


Alena Laskavaia ---10/07/2015 09:35:51 PM---I submitted few patches for Image Browser a month ago to extend its functionality. I would really lo

From: Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx>
To: pde-dev@xxxxxxxxxxx
Date: 10/07/2015 09:35 PM
Subject: [pde-dev] PDE patches for Image Browser
Sent by: pde-dev-bounces@xxxxxxxxxxx


---




I submitted few patches for Image Browser a month ago to extend
its functionality. I would really love somebody to have it reviewed (and submitted)

Bug 477016: Image Browser: needs path filter

Bug description:
I love image browser view (conceptually). To actually be useful it needs
a simple text filter that would filter on icon path text
otherwise there are two many images and cannot find anything.


https://git.eclipse.org/r/#/c/55602/


Second patch is to remove Show More... button which does nothing and not needed if we have filter


https://git.eclipse.org/r/#/c/55603/_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pde-dev