[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] Where to place ECF/p2 error translation/messages

Makes sense to have a new o.e.e.p2.repository bundle - I was just looking at IStateful in artifact repository, and was just contemplating moving it to p2.core.
I will rename the "transport" bundle I just created as suggested.

Regarding error codes - the best would naturally be if ECF had full abstraction of error codes - maybe an implementation in p2 can serve as a model? I am thinking of having a few higher order "transport" exceptions (malformed address, unknown transport, unknown host, (remote) file not found, unauthorized, timeout, etc) with details from underlying protocol.  Right now there are quite a few different exceptions that surface from the ECFTransport classes. It was quite interesting to run test with addresses faulty in different ways (behavior ranges from complete freeze and strange messages, to generic "can not connect to"). I intend to nail all of these down.


On Mar 3, 2009, at 4:05 PM, John Arthorne wrote:


If we introduce a new bundle, I suggest something like org.eclipse.equinox.p2.repository. Much of the common repository code (AbstractRepository, AbstractRepositoryManager, IRepository, etc), has steadily migrated into our lowest level bundle: org.eclipse.equinox.p2.core. This has pulled in extra dependencies onto core that are only needed by repositories (such as preferences). Having a base repository bundle would allow us to move all the common repository bits, including ECFTransport, into one place, and remove the extra weight from the core bundle.

Unrelated to that, it is a bit of a bummer that we're building such a tight dependency on  HTTP response codes in particular, since the theoretical advantage of ECF was that it provided protocol independence. Will ECF use the same error codes for other protocols (such as file)?

John




Henrik Lindberg <henrik.lindberg@xxxxxxxxxxxxxx>
Sent by: p2-dev-bounces@xxxxxxxxxxx

03/02/2009 06:51 PM

Please respond to
P2 developer discussions <p2-dev@xxxxxxxxxxx>

To
P2 developer discussions <p2-dev@xxxxxxxxxxx>
cc
Subject
Re: [p2-dev] Where to place ECF/p2 error translation/messages





There are actually three locations !!
There is an ECFTransport in org.eclipse.equinox.internal.p2.updatesite as well.


Henrik Lindberg
henrik.lindberg@xxxxxxxxxxxxxx



On Mar 2, 2009, at 10:49 PM, Henrik Lindberg wrote:

Hi,
I am working on better error messages in the o.e.e.internal.p2.artifact.repository.ECFTransport, and o.e.e.internal.p2.metadata.repository.ECFMetaDataTransport.
This involves mapping HTTP error codes to meaningful messages, and there is quite a few of them.

Seems wasteful to have a copy of the same implementation in both packages. Any suggestion for a common package where this can be placed?

Henrik Lindberg

henrik.lindberg@xxxxxxxxxxxxxx



_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev

_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev

_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev