Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orion-dev] Client - pending changes are lost when switching files and auto-save is enabled

Hi Tomer,

Note that the change "Editor is not dirty after failed save attempt" was made because it was possible to lose changes when the saving process failed for some reason (session time out, etc).   In that case, the undo stack was left in a clean state, but there were still outstanding changes.  The simplest fix for now is to revert the change since it seems that the current problem is more likely to happen.   But I believe we need to add support in the undo stack to revet to a previous clean state in order to fix both problems.

Silenio



From:        Tomer Ohana <tomero@xxxxxxx>
To:        Orion developer discussions <orion-dev@xxxxxxxxxxx>
Date:        05/04/2015 09:58 AM
Subject:        Re: [orion-dev] Client - pending changes are lost when switching files and auto-save is enabled
Sent by:        orion-dev-bounces@xxxxxxxxxxx




I will try to submit changes to Gerrit, thanks!

Anton, to answer our question, we are currently developing a product that involves an online IDE and we chose Orion.
We customize and extend the client heavily (unfortunately it's not that easy).
The server we wrote from scratch since it needs to work with our own backend.
I don't know if it's allowed to send images, but if so let me know and I can show our design.


On Mon, May 4, 2015 at 4:13 PM, Adrian Aichner <adrian.aichner@xxxxxxxxx> wrote:
This might also be interesting in this context:

[Subject: auto-save-include-big-deletions](
https://lists.gnu.org/archive/html/emacs-devel/2009-07/msg01091.html)



On 04.05.2015 14:40, John Arthorne wrote:
Hi Tomer,

Yikes, that sounds serious. Yes please enter a bugzilla bug report for it. You can propose fixes either with a pull request, or even better by pushing to our Gerrit for review:


https://wiki.eclipse.org/Orion/Contributing_Code#Submit_your_changes_to_Gerrit

Thanks!


John




From:        
Tomer Ohana <tomero@xxxxxxx>
To:        
orion-dev@xxxxxxxxxxx
Date:        
05/03/2015 09:20 AM
Subject:        
[orion-dev] Client - pending changes are lost when switching files and auto-save is enabled
Sent by:        
orion-dev-bounces@xxxxxxxxxxx




Hi everyone,

We're using Orion in one of our products and found a serious bug. I think it originated from this commit: 

Editor is not dirty after failed save attempty

In short, when user edits a file, with auto-save enabled, the editor is marked clean although there are still unsaved changes.
This happens when the save function is called between user edits, meaning the user still edits the file while there is an outgoing save request.
When the response returns, the editor is marked clean (
inputManager:357) although there are still unsaved changes.
If the user switches to a different file or closes the browser window, those unsaved changes are lost.
Although it seems tricky to reproduce, it happens to us all the time.

I'm new here so I just wanted to ask if anyone encountered it too, or should I open a bug in BugZilla? Is it possible to suggest a fix via a pull request?

Thanks for the help,
Tomer.
_______________________________________________
orion-dev mailing list

orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/orion-dev


_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/orion-dev


_______________________________________________
orion-dev mailing list

orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/orion-dev



--
Head of front end development,
Wix Code

_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/orion-dev

Back to the top