[orion-dev] Client - pending changes are lost when switching files and a

[Tomer Ohana <tomero@xxxxxxx>]

Hi everyone,

We're using Orion in one of our products and found a serious bug. I think it originated from this commit: 

Editor is not dirty after failed save attempty

In short, when user edits a file, with auto-save enabled, the editor is marked clean although there are still unsaved changes.

This happens when the save function is called between user edits, meaning the user still edits the file while there is an outgoing save request.

When the response returns, the editor is marked clean (inputManager:357) although there are still unsaved changes.

If the user switches to a different file or closes the browser window, those unsaved changes are lost.

Although it seems tricky to reproduce, it happens to us all the time.

I'm new here so I just wanted to ask if anyone encountered it too, or should I open a bug in BugZilla? Is it possible to suggest a fix via a pull request?

Thanks for the help,

Tomer.