Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orion-dev] Editor changes - removing the IFRAME

I have been able to get the new embeddeditor to 'work', that is to show some text. But I think my next step is to put it back in an iframe. The problem I have is that the styles from the containing page (Web Inspector) prevent the editor from working. I could try to find all of the style problems and fix them by rules that work on .orion-editor, a div I put around the editor. But to me the iframe path seems attractive. The issue about the bug on mobile safari does not concern me.  Any other issue I should know about?

thanks,
jjb

On Fri, Mar 9, 2012 at 10:02 AM, Silenio Quarti <Silenio_Quarti@xxxxxxxxxx> wrote:

None that I can foresee. There was a change in the in embeddededitor.css/embeddededitor.js to move the stylesheet that used to be passed in the TextView creation into the page HTML, but I believe that does not affect you.

Silenio


From: John J Barton <johnjbarton@xxxxxxxxxxxxxxx>
To: Orion developer discussions <orion-dev@xxxxxxxxxxx>
Date: 03/09/2012 11:20 AM
Subject:
Re: [orion-dev] Editor changes - removing the IFRAME
Sent by: orion-dev-bounces@xxxxxxxxxxx







On Thu, Mar 8, 2012 at 1:17 PM, Silenio Quarti <Silenio_Quarti@xxxxxxxxxx> wrote:

I have merged the changes to remove the IFRAME that hosts the editor into master.


Unfortunately, some APIs in TextView had to be removed since they only made sense because of the IFRAME.  Hopefully I have updated all the places that made use of them in Orion. Please let me know if I missed any.  Sorry about other users of the editor. Let me know if you need help updating.



Any special issue for use of the embedded editor example?
jjb
_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev



_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev



Back to the top