| Re: [orbit-dev] Multiple bundle recipes for httpclient-* vs. a single one for httpclient-osgi? |
Roland Grunberg wrote: > Initially I argued we should use httpclient-cache, > httpclient-fluent, httpclient, because maven central didn't have a > combined offering, so we shouldn't diverge from what was likely the > most common form of distributing. However, I could easily be wrong > because httpclient-osgi does exist and combines the above mentioned > bundles. Got it. >> - A shared commons-codec:commons-codec:1.9 >> >> That this is shaded rather than an imported is odd. (Also, we would >> need a CQ for this, as Orbit contains only 1.6.0 of >> commons-codec.) > > Any chance that it'll work against 1.6 ? If not, then we just need > to confirm the shaded version is identical to 1.9 and then just file > the CQs and of course excluded the shaded part from the final bundle > (replacing with proper osgi import-packages) The sources of httpclient 4.5.2 [1] with commons-codec.version set to 1.6 handle a "mvn clean verify" just fine, so I don't think commons-codec.version 1.9 is a hard requirement. >> And then there is this addition in httpclient-osgi: >> >> - The org.apache.http.osgi.* packages and an OSGI-INF/metatype >> directory >> >> I am not sure whether these would do any harm. >> >> I think I will try putting together recipes for both approaches, >> build AERI with either and see whether anything breaks when >> installed into M5. >> >> Does this sound reasonable? > > Sounds good. Any advice how to write an osgi.bnd file such that it takes everything except Bundle-Vendor and a few other descriptive headers from the MANIFEST.MF already included in httpclient-osgi? I've consulted the options of ebr-maven-plugin:help but couldn't find anything that would help me in this regard; AFAICT, the ebr-maven-plugin always want to create a MANIFEST.MF from scratch. Is this correct? Anyway, I'll try to create bundle recipes for httpclient-cache, fluent-hc, etc. first and report back on the progress. Best wishes, Andreas [1] <http://www-eu.apache.org/dist//httpcomponents/httpclient/source/httpcomponents-client-4.5.2-src.zip> -- Codetrails GmbH The knowledge transfer company Robert-Bosch-Str. 7, 64293 Darmstadt Phone: +49-6151-276-7092 Mobile: +49-170-811-3791 http://www.codetrails.com/ Managing Director: Dr. Marcel Bruch Handelsregister: Darmstadt HRB 91940
Attachment:
signature.asc
Description: OpenPGP digital signature