Re: [orbit-dev] Logback slf4j impl 1.0.3

[David M Williams <david_williams@xxxxxxxxxx>]

> David, what do you think? Is it necessary
for consistency (there are
> ch.qos.logback.slf4j 0.9.27 and 1.0.0 in Orbit) to add 
> ch.qos.logback.slf4j_1.0.3 bundle, although it will export the same
> packages with the same version, 1.6.4, as ch.qos.logback.slf4j_1.0.0
bundle?

I'd have to look close to understand
what you are really asking (if I could even then :)  but can give
some general guidelines: 

a) we want to mimic what ever the third
party provider does as closely as possible, so if you are saying they provide
two jars with different versions (but same packages) then yes, we'd want
another bundle with different version (even though same packages). 

b) We do need to satisfy both the "import
package" users and the "require bundle" users, so, not always
bad to have same packages come from two bundles (as said, to avoid confusion
on what goes with what). 

c) If we do have the same packages exported
by two bundles, then that is an especially important case where you want
each bundle that exports the packages, to also import the packages. That
way, if both bundles are in the stack, the  class-loading order won't
hurt anything, there would always be only one "winner" and you
won't get those weird "class cast" exceptions. 

If this doesn't help much, I can look
at this closer over the next few days ... but will need to find an hour
or so to really focus and read and look at the bundles you are asking about.


Thanks, 





From:      
 "Kirchev, Lazar"
<l.kirchev@xxxxxxx>
To:      
 Gunnar Wagenknecht
<gunnar@xxxxxxxxxxxxxxx>, "orbit-dev@xxxxxxxxxxx" <orbit-dev@xxxxxxxxxxx>,

Cc:      
 "orbit-dev@xxxxxxxxxxx"
<orbit-dev@xxxxxxxxxxx>
Date:      
 08/23/2012 09:32 AM
Subject:    
   Re: [orbit-dev]
Logback slf4j impl 1.0.3
Sent by:    
   orbit-dev-bounces@xxxxxxxxxxx

---

>I'm not sure on this one. IMHO there is no technical
need for a new
>bundle. However, for consistency/easy-of-verification reasons it might
>make sense to add the bundle.

I also think that there is no need for a new bundle. 

David, what do you think? Is it necessary for consistency (there are ch.qos.logback.slf4j
0.9.27 and 1.0.0 in Orbit) to add ch.qos.logback.slf4j_1.0.3 bundle, although
it will export the same packages with the same version, 1.6.4, as ch.qos.logback.slf4j_1.0.0
bundle?

-----Original Message-----
From: Gunnar Wagenknecht [mailto:gunnar@xxxxxxxxxxxxxxx]
Sent: Thursday, August 23, 2012 3:29 PM
To: Kirchev, Lazar
Cc: orbit-dev@xxxxxxxxxxx
Subject: Re: Logback slf4j impl 1.0.3

Am 23.08.2012 14:18, schrieb Kirchev, Lazar:
> Since the version for 1.0.3 is the same, does it make sense to add
to
> Orbit bundle ch.qos.logback.slf4j_1.0.3, differing from
> ch.qos.logback.slf4j_1.0.0 only by the bundle version?

I'm not sure on this one. IMHO there is no technical need for a new
bundle. However, for consistency/easy-of-verification reasons it might
make sense to add the bundle.

> Or, to add Loback classic with the slf4j implementation contained
in its
> bundle?

The Logback+SLF4J bundles follow a different approach in Orbit in order
to avoid a cyclic dependency issue between SLF4J and any implementation.
The lockback.slf4j bundle is actually a fragment to the slf4j.api
bundle. It delivers the implementation as a fragment to SLF4J. I'd
prefer to keep it that way.

-Gunnar


-- 
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx
http://wagenknecht.org/
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev