[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [orbit-dev] Proposal for adding bundles
|
> ... I had looked at java.xml which has the jar included ...
For the problem your fresh eyes have discovered, I have opened
Bug 365186 - javax.xml has extra (original) jar in CVS
> May I continue to integrate the bundles in the build?
Go for it. You are now at what some would say is "the hard part" ...
getting the map file right and feature.xml and getting them all released
together.
It is recommended you commit these changes at a time where you will "be
around" for a few hours, in case there is a problem, and you need to revert
or make a quick fix.
I think it would be good if you get these in for our "M4" delivery (which
is Friday) which doesn't leave much time, but its probably worth trying ...
just be prepared to revert if some really weird problem is found that
breaks the build that can't be tracked down by, say, Thursday.
Naturally, even once in a build ... even once in a milestone ... you (or
others) might find some problem that requires a fix in a subsequent build,
or milestone ... but, that is a normal part of the process. (That is,
things things don't have to be perfect the first time ... I'd guess about
50% of the time some change is required after the initial check in and
build ... sometimes, years later, as you've seen in the javax.xml case :)
Thanks,
From: Andreas Weber <Andreas.Weber@xxxxxxxxxxxxx>
To: Orbit Developer discussion <orbit-dev@xxxxxxxxxxx>,
Date: 11/30/2011 04:24 AM
Subject: Re: [orbit-dev] Proposal for adding bundles
Sent by: orbit-dev-bounces@xxxxxxxxxxx
Hi David,
thanks for your feedback!
> 1. It appears you have checked in the original .jar file, as well as the
exploded
> .class files. We normally just do the .class files. (But ... this is from
quick peek
> ... maybe those jars are for something else?)
Well, I had looked at java.xml which has the jar included, so I just did it
the same way.
But in my case there's no need for the jars, so I removed them.
> 2. for the BREE, you have
> Bundle-RequiredExecutionEnvironment: JavaSE-1.6
You are right, I just missed to adapt this setting.
I changed the values now. (For com.novell.ldap I couldn't find a useful
hint, so I set a version for which I know that we used it before in our
project)
Some more comments?
May I continue to integrate the bundles in the build?
Cheers,
Andreas
> -----Ursprüngliche Nachricht-----
> Von: orbit-dev-bounces@xxxxxxxxxxx [mailto:orbit-dev-
> bounces@xxxxxxxxxxx] Im Auftrag von David M Williams
> Gesendet: Dienstag, 29. November 2011 21:59
> An: Orbit Developer discussion
> Betreff: Re: [orbit-dev] Proposal for adding bundles
>
>
> They look nearly ready to me. Two comments though.
>
> 1. It appears you have checked in the original .jar file, as well as the
exploded
> .class files. We normally just do the .class files. (But ... this is from
quick peek
> ... maybe those jars are for something else?)
>
> 2. for the BREE, you have
> Bundle-RequiredExecutionEnvironment: JavaSE-1.6
>
> 1.6? Really? That certainly could be accurate, but seems fairly rare that
a
> general purpose "library" would require such a high level of JRE. But
could be
> accurate ... just jumped out at me ... you might want to double check
with
> original project's website to see if they say anything specific ... we
strive to
> keep those BREEs as low as possible, so can be used by the widest range
of
> consumers.
>
> Hope that helps.
>
>
>
>
>
> From: Andreas Weber <Andreas.Weber@xxxxxxxxxxxxx>
> To: Orbit Developer discussion <orbit-dev@xxxxxxxxxxx>,
> Date: 11/29/2011 08:50 AM
> Subject: Re: [orbit-dev] Proposal for adding bundles
> Sent by: orbit-dev-bounces@xxxxxxxxxxx
>
>
>
> Hi,
>
> > You should also have someone who has
> > packaged bundles in Orbit before review your changes before you update
> > the Orbit .map files. The best way to do this would be to email the
> mailing list
> > when you're further along.
>
> I checked in new bundles "com.novell.ldap" and
> "org.apache.commons.dbcp" to the CVS repository (head+branch).
> Would be great if someone could have a look at the bundles and tell me if
> they are ok.
> After a positive review I will update the featue, map and project set
file
> which I haven't done yet.
>
> Regards,
> Andreas
>
> > -----Ursprüngliche Nachricht-----
> > Von: orbit-dev-bounces@xxxxxxxxxxx [mailto:orbit-dev-
> > bounces@xxxxxxxxxxx] Im Auftrag von Chris Aniszczyk
> > Gesendet: Montag, 14. November 2011 19:04
> > An: Orbit Developer discussion
> > Cc: Smila project developer mailing list
> > Betreff: Re: [orbit-dev] Proposal for adding bundles
> >
> > On Mon, Nov 14, 2011 at 7:21 AM, Andreas Weber
> > <Andreas.Weber@xxxxxxxxxxxxx> wrote:
> > > Hi Orbit team,
> > >
> > > in our SMILA project (http://eclipse.org/smila/) we use third party
> > components that other projects are also interested in. So we would
> > like
> to
> > share/provide these bundles in Orbit. it's:
> > > - com.novell.ldap
> > > - org.apache.commons.dbcp
> > >
> > > These bundles are not contained in Orbit repository yet, but are
> already
> > approved for SMILA project.
> > >
> > > If I understand the process of adding bundles to Orbit correctly, we
> have -
> > in short summary - to manage the following steps:
> > > * Propose bundles in orbit mailing list (done)
> >
> > Please create bugs for these in Orbit so they can be tracked.
> >
> > > * Propose a (new) committer for adding and maintaining those bundles
> > > - well, this would be me :)
> >
> > I nominated you as a committer to maintain these bundles,
> > congratulations and welcome!
> >
> > > * After committer election, raising piggyback CQs for the new
> > > bundles
> >
> > I could raise the piggyback CQs now if you give me the proper #'s to
> > help speed things along.
> >
> > > * Adding the bundles to Orbit's CVS repository
> >
> > Yep, this is the normal set of steps. You should also have someone who
> has
> > packaged bundles in Orbit before review your changes before you update
> > the Orbit .map files. The best way to do this would be to email the
> mailing list
> > when you're further along.
> >
> > --
> > Cheers,
> >
> > Chris Aniszczyk
> > http://aniszczyk.org
> > +1 512 961 6719
> > _______________________________________________
> > orbit-dev mailing list
> > orbit-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/orbit-dev
> _______________________________________________
> orbit-dev mailing list
> orbit-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/orbit-dev
>
>
> _______________________________________________
> orbit-dev mailing list
> orbit-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/orbit-dev
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev
