Re: [mylyn-reviews-dev] Mylyn Common Model GitHub build

[Robert Munteanu <robert.munteanu@xxxxxxxxx>]

Hi Miles,

On Sun, Oct 7, 2012 at 10:11 PM, Miles Parker <miles.parker@xxxxxxxxxxx> wrote:
>
> Hi Robert,
>
> That was one of the only major changes. We've changed the name to "locations" and set the cardinality to 0..*. This is because R4E actually supports multiple locations per topic, which when you think about it is a very nice feature to have. :) Of course if you only expect to have one location per topic you can just provide/use that.

Thanks, I've adapted the code to use that ( without any testing ). A
couple of questions though:

1. Is topic.getLocations().add(location); the expected way to add a
new location?
2. What is the Bundle-Version in which you expect these changes to end
up? I would like to restrict installation of the connector with
incompatible versions
3. When do you expect to publish this new version of the reviews bundle?

Robert

>
> Here's an example of a change we've made for Gerrit:
>
> https://git.eclipse.org/r/#/c/7908/6/org.eclipse.mylyn.gerrit.ui/src/org/eclipse/mylyn/internal/gerrit/ui/GerritReviewBehavior.java
>
> hth,
>
> Mile
>
> On 2012-10-07, at 6:32 AM, Robert Munteanu <robert.munteanu@xxxxxxxxx> wrote:
>
>> On Wed, Oct 3, 2012 at 8:04 PM, Miles Parker <miles.parker@xxxxxxxxxxx> wrote:
>>>
>>> We now have a nightly build for the Reviews github fork, building off of the "commonModel" branch. You can get it from:
>>>
>>> http://ci.mylyn.org/job/Mylyn-Reviews-GitHub/
>>>
>>> [There is also an R4E build, but it's not currently building.
>>>
>>> http://ci.mylyn.org/job/Mylyn-Reviews-R4E-GitHub/]
>>>
>>> Please let us know if you have any troubles consuming from there.
>>
>> Miles, thanks for taking the time to set up this build. I have two
>> compilation errors, related to ITopic.get/setLocation being gone. How
>> should I replace those?
>>
>> Robert
>>
>>>
>>> On 2012-10-01, at 12:30 PM, Robert Munteanu <robert.munteanu@xxxxxxxxx> wrote:
>>>
>>>> On Mon, Oct 1, 2012 at 10:22 PM, Miles Parker <miles.parker@xxxxxxxxxxx> wrote:
>>>>> We're trying to avoid disrupting API too much,
>>>>
>>>> Do you have a nightly build I can consume? I use the reviews API in
>>>> the ereviewboard connector.
>>>>
>>>> --
>>>> Sent from my (old) computer
>>>> _______________________________________________
>>>> mylyn-reviews-dev mailing list
>>>> mylyn-reviews-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>>>
>>> _______________________________________________
>>> mylyn-reviews-dev mailing list
>>> mylyn-reviews-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>>
>>
>>
>> --
>> Sent from my (old) computer
>> _______________________________________________
>> mylyn-reviews-dev mailing list
>> mylyn-reviews-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>
> _______________________________________________
> mylyn-reviews-dev mailing list
> mylyn-reviews-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev



-- 
Sent from my (old) computer