Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-reviews-dev] Mylyn Common Model GitHub build

On 2012-10-11, at 12:31 PM, Robert Munteanu <robert.munteanu@xxxxxxxxx> wrote:
> 1. Is topic.getLocations().add(location); the expected way to add a
> new location?

Yes, but of course in the case where you want to retain the old semantics -- that is treat it as a 0..1 setter -- you'll want to be sure to clear the list first.

> 2. What is the Bundle-Version in which you expect these changes to end
> up? I would like to restrict installation of the connector with
> incompatible versions

1.1. See prior discussion WRT whether we should do a major version bump. Let us know if you have an opinion on that.

> 3. When do you expect to publish this new version of the reviews bundle?

I don't believe there is a firm release date for 1.1 (?) defined yet. I'm not yet a committer, so we'll have to get these changes through EDP approval and review process.

BTW, as you're the only (known) other consumer of the tool besides Gerrit and R4E, I would love to hear ideas you might have about enhancing the model design. You can comment on this bug:

324327: Define a common model for reviews https://bugs.eclipse.org/bugs/show_bug.cgi?id=324327

cheers,

Miles




Back to the top