RE: [mylar-dev] changes to AbstractQueryHit

["Mik Kersten" <beatmik@xxxxxxx>]

Only JIRA has a notion of keys that is independent of IDs (the latter being
the robust one that doesn't change when tasks move between projects).  So
that's only being externalized by the JiraTaskExternalizer.

But I just verified that with your latest patches hits do restore for the
web connector.

Mik

 
> -----Original Message-----
> From: mylar-dev-bounces@xxxxxxxxxxx [mailto:mylar-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Eugene Kuleshov
> Sent: Thursday, November 02, 2006 10:41 PM
> To: Mylar developer discussions
> Subject: Re: [mylar-dev] changes to AbstractQueryHit
> 
> Mik,
> 
>   Can you please check if
> DelegatingTaskExternalizer.createQueryHitElement(..) should be also
> setting KEY_KEY QueryHit.getId() ?
> 
>   It doesn't seem like I've changed this, but I see that query hits are
> not being completely restored after Eclipse restart. Strange that hits
> that have tasks created are restored.
> 
>   Thanks
> 
>   Eugene
> 
> 
> Mik Kersten wrote:
> > While making the JIRA Connector support search and hits (bug linked
> below) I
> > fixed up the AbstractQueryHit class and all of the connectors' classes
> > extending it.  As expected, there was considerable duplication of code
> > because AbstractQueryHit was not encapsulating the policy of how hits
> > correspond to tasks.  That's done now, so all of the subclasses of
> > AbstractQueryHit are way shorter and only provide connector-specific
> > mappings (e.g. JiraQueryHit's need for keys in addition to IDs, the
> > WebQueryHit's special mapping of URLs).
> >
> > support search integration for JIRA
> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=162651
> >
> > Steffen: please run through a few of the manual tests for the Trac
> connector
> > before tomorrow evening when we put out the 3.3M3 dev build, or let me
> know
> > if you can't
> >
> > Eugene: please do the same for the generic web connector.
> >
> > Rob: the changes ensure that all connectors use the same policy, so this
> had
> > an impact on both externalization and the Bugzilla connector.
> >
> > All: note that testPredictedElementPopulatoinOfTypeHistory is failing,
> until
> > we re-implement the Open Type dialog changes for 3.3M3.  AllTests should
> > pass again by tomorrow.
> >
> > Mik
> >
> > --
> > Mik Kersten, http://kerstens.org/mik
> > Mylar Project Lead, http://eclipse.org/mylar
> >
> >
> > _______________________________________________
> > mylar-dev mailing list
> > mylar-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/mylar-dev
> >
> 
> _______________________________________________
> mylar-dev mailing list
> mylar-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylar-dev