Re: [mosquitto-dev] Version 2.0

[Roger Light <roger@xxxxxxxxxx>]

I forgot to say - I've fixed the `WITH_TLS=no` build in the `fixes` branch.

Regards,

Roger

On Fri, 4 Dec 2020 at 23:48, Roger Light <roger@xxxxxxxxxx> wrote:
>
> Hi Peter,
>
> Thanks for your comments.
>
> > Maybe also mention that the license has been changed from EPL v1.0 to
> > v2.0?
>
> Yes, that's a very good point.
>
> > On a related note, where can I fetch your updated gpg key?
>
> I updated it a long while back and am pretty certain it's on a key
> server - the docker builds would fail if the signature wasn't valid.
> I've sent it again, to hkp://pgp.surfnet.nl , so please refresh.
>
> > Trying it out in Buildroot, I see that the cJSON logic hard codes
> > include and linker paths, which naturally doesn't work for cross
> > compilation. Any specific reason to not use pkg-config? cJSON provides a
> > .pc file:
>
> This has been pointed out elsewhere, and all I can say is that it was
> an oversight brought over from a different project where I was using
> cJSON but compiled as part of the exe, so with the "wrong" header
> path. I've already removed the hard coded paths and fixed the includes
> in the `fixes` branch.
>
> > Compilation without openssl (WITH_TLS=no) is also broken because
> > password_mosq.c unconditionally includes a bunch of openssl
> > headers. I guess that should be inside an #ifdef WITH_TLS?
>
> Yes that's correct. I've tested the different build options many
> times, but in all of my tests the openssl headers have been available,
> even if not really used, which is why it didn't fail for me.
>
> Regards,
>
> Roger