Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [mdt-ocl.dev] Contribution/Reviews policy change proposal.

Hi Adolfo

This is similar to what I proposed quite some time ago, the main difference
was
that I tried to accommodate holidays, by partitioning the project into work
areas
with primary and secondary committers. These are indicated in
http://wiki.eclipse.org/MDT/OCL/Dev/Areas although I've not noticed anyone
other than
me updating this page.

Either primary or secondary committer could
notify an up-to two week holiday once every three months, thereby adding
up-to
two weeks to the 3 working day delay. I prefer 120 elapsed hours (or less)
to three
working days; it avoids time zone and weekend ambiguities.

I think the reviews are very important, and should not be bypassed just
because
one of us is on holiday. On the other hand we do want to make faster
progress
particularly with the M6 API freeze looming.

Sort of +1 with refinements.

	Regards

		Ed
> 
> I want to propose a new more flexible contribution/review policy.
> 
> It has been demonstrated that most of us are quite busy with 
> our daily 
> work, and some times the progress of the project is blocked 
> because the 
> patches are slowly reviewed. The idea could be the following:
> 
> - An attached patch should always comply the following premises:
>      1. The patched code must make the JUnit tests pass.
>      2. API Tooling must be happy with it.
> - Unless the reporter requires an special reviewing because of an 
> important design decision, the patch could be committed after 
> 3 natural 
> days (Monday-Driday), so that any of us with available time has a 
> considerable time (2 days) to review it and it's not 
> certainly blocked 
> if nobody have time to do the review.
> 
> So, for instance, If I attach a patch to a bugzilla on Friday, any of 
> you could add any review or revision on Monday and Tuesday. If no 
> comments are received I could commit the changes on Wednesday.
> 
> What do you think ?
> 
> Cheers,
> Adolfo.
> -- 
> 
> 	*Adolfo Sánchez-Barbudo Herrera*
> adolfosbh(at)opencanarias(dot)com 
> <mailto:adolfosbh%28at%29opencanarias%28dot%29com>
> C/Elías Ramos González, 4, ofc. 304
> 38001 SANTA CRUZ DE TENERIFE
> Tel.: +34 922 240231 / +34 617 718268
> 
> 

****************************************************************************
Please consider the environment before printing this email.
****************************************************************************
Thales Research and Technology (UK) Limited DISCLAIMER:  The information
contained in this e-mail is confidential.  It may also be legally
privileged.  It is intended only for the stated addressee(s) and access to
it by any other person is unauthorised.  If you are not an addressee, you
must not disclose, copy, circulate or in any other way use or rely on the
information contained herein.  Such unauthorised use may be unlawful.  We
may monitor all e-mail communications through our networks.  If you have
received this e-mail in error, please inform us immediately on +44 (0)1293
575987 and delete it and all copies from your system.  We accept no
responsibility for changes to any e-mail which occur after it has been sent.
Attachments to this e-mail may contain software viruses which could damage
your system.  We therefore recommend you virus-check all attachments before
opening.  The registered office of Thales Research and Technology (UK)
Limited is at: 2 Dashwood Lang Road, The Bourne Business Park, Addlestone,
Weybridge, Surrey KT15 2NX.  Registered in England No. 774298.
****************************************************************************




Back to the top