Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jetty-dev] org.eclipse.jetty.jsp.JettyLog and com.sun.org.apache.commons.logging package

jsp-2.1 from Glassfish relies on a com.sun.org.apache.logging
implementation for log output from the jsp engine. So we need
to bridge that logging to the jetty logger and this is the
purpose of the o.e.j.jsp.JettyLog.

With jsp-2.2 (in jetty-8), the dependency on
com.sun.org.apache.logging has been removed, and uses
java logging instead (which brings its own headaches with
trying to integrate with jetty logging - a problem that is
not solved at present).

regards
Jan


On 09/07/10 02:01, Hugues Malphettes wrote:
Hi Dmytro,

The reference implementation of jsp-1.2 provided by glassfish had some
internal dependencies that were not acceptable on com.sun.org.apache.*
packages. com.sun.org.apache.commons.logging.Log of was one of those.
It was changed to make it pluggable.
org.eclipse.jetty.jsp.JettyLog provides an actual implementation for the
logger.
Note that it is in fact optional to provide the logger for the jsp engine.

Jan or Greg could probably shed more light about this if necessary.
Things should be a lot cleaner on the next version of the jsp spec.

I am following up on the related bug:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=317222
Cheers,
Hugues.

On Thu, Jul 8, 2010 at 3:41 AM, Dmytro Pishchukhin
<dmytro.pishchukhin@xxxxxxxxx <mailto:dmytro.pishchukhin@xxxxxxxxx>> wrote:

    Hi,

    I'm trying to create jetty-aggregate-server-all OSGi bundle. I found
    that I have to import com.sun.org.apache.commons.logging package
    that is a part of org.mortbay.jetty/jsp-2.1-glassfish artifact.

    After some code analysis I found that org.eclipse.jetty.jsp.JettyLog
    class in used only to enable JSP logging. Are any reasons why
    standard Jetty org.eclipse.jetty.util.log is not used in this case?

    Thanks.

    Best regards,
    Dmytro Pishchukhin

    _______________________________________________
    jetty-dev mailing list
    jetty-dev@xxxxxxxxxxx <mailto:jetty-dev@xxxxxxxxxxx>
    https://dev.eclipse.org/mailman/listinfo/jetty-dev




_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/jetty-dev

--
Jan Bartel, Webtide LLC | janb@xxxxxxxxxxx | http://www.webtide.com


Back to the top