[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[incquery-dev] QE refactor
|
Hi
I have finished the refactor of the Query Explorer but I have some
doubts / remarks:
- The OrderBy annotation is not working properly on the current master
HEAD, this is now fixed in the Gerrit review. However, I have observed a
behavior which is maybe not what you would expect.
Take, for example, the pattern teacherNames from the school example.
Here, I have defined an ordering on the teacher's name (doesn't matter
if it is desc or asc for now). When you add a new teacher to the model,
the name will be null initially. The comparator will not be able to
define the position of this teacher, so it will be placed at the end of
the match set (list). When you modify the name in the properties view,
then you would expect that it will move to its correct position, but no
notification will be called for that, no change will happen in the
IObservableList, thus the element will remain at the end of the list.
- In the current master HEAD if you take a look at the
PatternMatcherContent class, then you can see that we are registering an
IncQueryModelUpdateListener for the IQ engine. When the engine becomes
tainted, then we will remove these listeners. I just want to make sure
that, this reg/unreg is not required at all anymore, because the
PatternMatcherContent (Gerrit) will use IncQueryObservables (and I
guess, it takes care of this thing), right?
https://git.eclipse.org/r/#/c/23459/
Cheers,
Tomi
