Re: [incquery-dev] Query Explorer refactor

[Tamás Szabó <tamas.szabo@xxxxxxxxx>]

Hi

I think this degradation is related to the refactor, I will soon take a 
look.

Cheers,
Tomi

2014.03.17. 11:22 keltezéssel, Ujhelyi Zoltán írta:
> Hi,
>
> I don't know whether the bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=430511 (opened just now) is a degradation because of the first part of your refactor, or an older issue, but I think, it is worth exploring as soon as possible.
>
> Thanks,
> Zoli
> -- Zoltán Ujhelyi
> https://www.inf.mit.bme.hu/en/members/ujhelyiz
>
> Fault Tolerant Systems Research Group
> Budapest University of Technology and Economics
>
> On 2014.03.16., at 13:15, Tamás Szabó <tamas.szabo@xxxxxxxxx> wrote:
>
> > Hi
> >
> > 2014.03.16. 11:28 keltezéssel, Ábel Hegedüs írta:
> > > Hi,
> > > > On 2014.03.15. 17:01:07, Tamás Szabó <tamas.szabo@xxxxxxxxx>wrote:
> > > >
> > > > Hi
> > > >
> > > > * @Abel: is it possible to change the filtering partial match after it
> > > > has been set for the first time. This is an important question, because
> > > > when, for example, the patterns are reloaded, the current match set will
> > > > be removed and it will be recreated.
> > > Abel: Changing the filter match (simply calling setParam) after setting it is not supported. The EVM Rule must be removed and added with the new filter.
> > > > * When a new filter is set in the UI, I also need to update the contents
> > > > of the tree viewer. Can this be handled somehow with this
> > > > ObservablePatternMatchList? Basically I would like to see something like
> > > > setFilter, which would then update the contents accordingly (and also
> > > > send the notifications about it).
> > > Abel: Yes, it may possible to handle this inside a setFilter method. You would need to (1) disconnect the cache from the updater (2) remove the EVM rule with the old filter (3) add the new rule with the new filter (4) put matches into a new cache (5) create diff between old and new cache and send it as list update. Note that this is similar to the update mechanism of computed lists, but we only have to do this when setFilter is called, and it won't be called by multiple threads at the same time for a given observable.
> > Ok. Can you support me with the implementation of such a functionality in the ObservablePatternMatchList class? I have pushed a gerrit code review with my initial contribution. This one does not support the setting of a filter from the UI yet.
> >
> > Cheers,
> > Tomi
> >
> > _______________________________________________
> > incquery-dev mailing list
> > incquery-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/incquery-dev
> _______________________________________________
> incquery-dev mailing list
> incquery-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/incquery-dev

--
Tamás Szabó
Software Engineer

Tel.:   +49 711 342 191 0
Fax.:   +49 711 342 191 29
Mobil:  +49 171 565 416 9
Web:    www.itemis.de
Mail:   tamas.szabo@xxxxxxxxx
Skype:  szabta89

itemis AG
Niederlassung Süd
Meitnerstr. 10
70563 Stuttgart

Rechtlicher Hinweis:
Registergericht: Amtsgericht Dortmund HRB 20621 | Sitz der Gesellschaft:
Lünen
Vorstand: Jens Wagener (Vorsitzender) | Wolfgang Neuhaus | Dr. Georg
Pietrek | Jens Trompeter | Sebastian Neus
Aufsichtsrat: Prof. Dr. Burkhard Igel (Vorsitzender) | Stephan Grollmann
| Michael Neuhaus