Re: [imp-dev] Try out this patch!

["Jurgen Vinju" <Jurgen.Vinju@xxxxxx>]

Hi Antoine,

Sure, not problem!

Jurgen

On Thu, Jun 5, 2008 at 3:31 PM, Antoine Toulme <antoine@xxxxxxxxxxxxxxx> wrote:
> Hi,
>
> it is best to attach your contributions to bugzilla. This way the project
> can create a IP log of contributions, and you check a little box when
> registering on bugs.eclipse.org that makes it possible for committers to
> take and copy your code into the Eclipse codebase.
>
> I know that's a bi restriction, but it really is the only way to manage the
> Eclipse code base on the long term.
>
> Thanks,
>
> Antoine
>
> On Thu, Jun 5, 2008 at 3:23 PM, Jurgen Vinju <Jurgen.Vinju@xxxxxx> wrote:
>>
>> Hi guys,
>>
>> This is a patch for imp.runtime which allows IDE developers to add
>> arbitrary things to:
>>  a) the editor popup menu
>>  b) the [ct]oolbar
>>  c) the status bar
>>  d) the menu bar at the top of the screen
>>
>> It reuses an Eclipse design mostly, except for the popup menu which is
>> built on the previous
>> implementation of ILanguageActionContributor.
>>
>> The nice thing is that for toolbar,statusbar and menubar the additions
>> are encapsulated in
>> a 'subbar', which can be activated and deactivated at leisure. I use
>> this to hide stuff when
>> an editor is out of focus, even though all IMP editors have the
>> UniversalEditor editorid.
>>
>> Note: this hiding/reappearing stuff does not work for toolbars. It
>> seems that toolbars
>> are supposed to be static in Eclipse, as opposed to the menubar and
>> the status bar.
>>
>> I've used this feature to make editor additions for ASF+SDF
>> Meta-Environment on Eclipse,
>> the status bar now has a dropdown box to select the 'language' for
>> example.
>> Also, we've made a new extension point which uses the new
>> ILanguageActionContributor
>> to generate (nested) menu's from XML descriptions. This also works fine.
>>
>> In other words, I've tested the code, I like it. Shall I commit it? It
>> will break all existing
>> implementations of ILanguageActionContributor which need to be changed to
>> extend
>> DefaultLanguageActionContributor, after which they will work again,
>> with a @deprecation warning.
>>
>> Cheers,
>>
>> Jurgen
>>
>> _______________________________________________
>> imp-dev mailing list
>> imp-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/imp-dev
>>
>
>
>
> --
> http://www.lunar-ocean.com/blog
>
> _______________________________________________
> imp-dev mailing list
> imp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/imp-dev
>
>