[imp-dev] How to do code review and the Atlantic ocean

["Jurgen Vinju" <Jurgen.Vinju@xxxxxx>]

Hi!

I was just thinking about how to do this code reviewing stuff. The
scenario is that
one of us (an IMP committer that is) has cool new code, or a nice
bugfix to add to IMP,
but first wants the rest to review the code.

Possibilties:
  a) We email the code to each other, and chat about on the phone [not good]
  b) We make a bugzilla entry and attach a patch, and CC everybody we
want to review the code [ok-ish]
  c) We make a branch in subversion and organize via bugzilla to
review the code and merge the code
      to the trunk [good]

I like the third possibility best because then we can all contribute
to improve the 'patch' before it is
merged to the trunk. Also the patching process itself is taken care of
by subversion, and bugzilla
helps us to keep track of things that still need merging or reviewing.

The new code will be easily traceable via subversion, and the process
of reviewing and merging it via bugzilla.

Whadyathink?

Jurgen

P.S. Of course, non-committers should always attach a patch to a bugreport.