[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [imp-dev] How to do code review and the Atlantic ocean
|
Jurgen Vinju wrote:
Hi!
I was just thinking about how to do this code reviewing stuff. The
scenario is that
one of us (an IMP committer that is) has cool new code, or a nice
bugfix to add to IMP,
but first wants the rest to review the code.
Possibilties:
a) We email the code to each other, and chat about on the phone [not good]
b) We make a bugzilla entry and attach a patch, and CC everybody we
want to review the code [ok-ish]
c) We make a branch in subversion and organize via bugzilla to
review the code and merge the code
to the trunk [good]
Generally, (c) seems the right way to go, though I think it's a good idea
to discuss the intention of the patches/additions even before branching,
so the community can decide whether the feature/fix is basically pointing
in the right direction (well motivated, has roughly the right design, etc.).
I like the third possibility best because then we can all contribute
to improve the 'patch' before it is
merged to the trunk. Also the patching process itself is taken care of
by subversion, and bugzilla
helps us to keep track of things that still need merging or reviewing.
Agreed.
--
Cheers,
-- Bob
--------------------------------
Robert M. Fuhrer
Research Staff Member
Programming Technologies Dept.
IBM T.J. Watson Research Center
IMP Team Lead (http://eclipse-imp.sourceforge.net)
X10: Productivity for High-Performance Parallel Programming (http://x10.sf.net)
