Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [higgins-dev] diffs for DigitalSubject -> Node refactor
Jim,

Should we have an INodeId interface, in the same manner as we have a IContextId interface?

I could imagine the following method in IdASRegistry:

INode createNode(INodeId nodeId)

.. just like there is

IContext createContext(IContextId contextId)

today.

Markus

On Feb 12, 2008 7:36 PM, Jim Sermersheim <jimse@xxxxxxxxxx> wrote:

It's done

https://bugs.eclipse.org/bugs/show_bug.cgi?id=218728

http://dev.eclipse.org/viewsvn/index.cgi?view=rev&root=Technology_SVN&revision=9373

>>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 02/12/08 2:53 PM >>>

looks like I'm the only one reading my messages.


Here's the .psf for real this time.

>>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 02/12/08 11:51 AM >>>

BTW, attached is the .psf that represents the projects I had checked out when I did the refactoring.  Let me know if I missed any that have IdAS dependencies.


I plan to commit in a few hours unless I hear otherwise


Jim

>>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 02/12/08 9:38 AM >>>

I'm not sure why it's not showing up when you apply the patch.  It's in the diff.  Look at org.eclipse.higgins.idas.api.diff starting at line 698.  IFilterNodeIDAssertion used to be called IFilterSubjectIDAssertion


Maybe the Apply Patch process is faulty?


Jim

>>> "Sergey Lyakhov" <slyakhov@xxxxxxxxxxxxxx> 02/12/08 8:22 AM >>>

Jim,

                                                 

I have some problems to apply your patch for idas.api project. I can not patch some classes like IFilterNodeIDAssertion. Also I see that the latest revision number of https://dev.eclipse.org/svnroot/technology/org.eclipse.higgins/trunk/plugins/org.eclipse.higgins.idas.api is 7644 and there is no IFilterNodeIDAssertion.java file in this repository. However the .diff file contains data for IFilterNodeIDAssertion.java (revision 9288). Where is the problem? Am I doing something wrongly, or there is a problem with the path?

                                                 

Thanks,
Sergey Lyakhov

----- Original Message -----

Sent: Tuesday, February 12, 2008 5:47 AM

Subject: [higgins-dev] diffs for DigitalSubject -> Node refactor


All,


At Paul's request, I've renamed DigitalSubject to Node as well as a lot of supporting word changes.


Please review the .diff files attached to see if there's anything that I missed or that you don't like.  I'll commit tomorrow if no one has issues.


Jim


p.s.  How do you get the subversion plugin to let you do one big diff over all the projects?






_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev


_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev


Back to the top