Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [higgins-dev] configuration update
The mapConfigurationSettings parameter is an IN parameter, in case the configuration handler needs to be given some info.  (For example, you *could* pass in a configuration file name this way.)  The getSettings method is used to retrieve the configuration settings that are read/created by the handler.

...Greg


Tom Doman wrote: 
1. I'd vote for XMLConfigurationHandler.
2. In IConfigurationHandler.configure, is the mapConfigurationSettings parameter only an OUT parameter?
3. I think Jim's approach with IdAS has been to do separate projects though I don't mind separate packages.  Maybe Jim can weigh in on why the move toward separate projects.  I think that was mostly so developers could choose just the pieces that they absolutely needed.

Tom

  
Greg Byrd <gbyrd@xxxxxxxx> 5/22/2007 9:54 AM >>>
        
Here's what I've done in my local workspace for the configuration stuff.  I'd like some feedback before checking in.

(1) Changed org.eclipse.higgins.configuration.common to org.eclipse.configuration.impl.  Includes two packages: ...configuration.common and ...configuration.xml.  The first holds ConfigurableComponentFactoryHelper, and the second holds all of the other implementation stuff from Mike.

(2) Moved all XML-specific stuff (ISettingHandler) out of org.eclipse.higgins.configuration.api.

(3) Added IConfigurationHandler interface in the api package.  It has the following three methods, modeled after Mike's ConfigurationHandler class:

    public abstract void setConfigurationBase(String str); -- set directory for finding config files (if any)
        
    public abstract boolean configure(java.util.Map mapConfigurationSettings) throws Exception;  -- create config mapping
   
    public abstract java.util.Map getSettings() throws Exception; -- return config mapping


Except for package names, Mike's code should still work.  (Any votes for changing ConfigurationHandler to XMLConfigurationHandler?)

Comments?  I wasn't sure about whether to do separate projects for the impl stuff vs. separate packages.

...Greg



_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev

Back to the top