I should have mentioned that allowing setData to be called repeatedly does add one more level of things to keep track of for CP writers.
Jim
>>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 4/25/07 6:59 PM >>>
I noticed that ISimpleValue.setData(Object) is under-specified. We need to agree on whether this may be called multiple times (in which case it could be used to change a property value's data while leaving the type alone), or whether it can only be called once to set the data.
I had originally intended it to be called once, (after the consumer called IProperty.addValue(URI)), but it seems like it would be nice to allow it to be called over and over. See this for examples of what must be done to change a property value (when there are multiple values). The first is where we are not allowed to call setData after the data has been set, and the second is where setData is allowed. The second cuts out two lines of code.
Jim
>>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 4/24/07 4:39 PM >>> I updated both the diff and javadoc with javadoc fixes
>>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 4/24/07 4:15 PM >>> oops, here's the diff
>>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 4/24/07 4:09 PM >>>
Please review and let me know if there are issues. Otherwise, I hope to check these changes in either tomorrow or Thursday.
I will fix the various Javadoc errors and begin implementing the new Basic* methods in the interim.
Jim
I'll move on to some use-case pseudo-code.
|