| Re: [higgins-dev] IdAS Update Proposals |
|
I noticed that ISimpleValue.setData(Object) is under-specified. We need to agree on whether this may be called multiple times (in which case it could be used to change a property value's data while leaving the type alone), or whether it can only be called once to set the data.
I had originally intended it to be called once, (after the consumer called IProperty.addValue(URI)), but it seems like it would be nice to allow it to be called over and over. See this for examples of what must be done to change a property value (when there are multiple values). The first is where we are not allowed to call setData after the data has been set, and the second is where setData is allowed. The second cuts out two lines of code.
Jim
>>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 4/24/07 4:39 PM >>> I updated both the diff and javadoc with javadoc fixes >>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 4/24/07 4:15 PM >>> oops, here's the diff >>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 4/24/07 4:09 PM >>> I've attached a diff of the update changes and put the javadoc here http://www.eclipse.org/higgins/org.eclipse.higgins.docs/idas/
Note that this is still missing the other set of changes that we're talking about at this page http://wiki.eclipse.org/index.php/IdAS_Update_Proposals_2. I plan to address those as a followup to the first wave of changes.
Please review and let me know if there are issues. Otherwise, I hope to check these changes in either tomorrow or Thursday.
I will fix the various Javadoc errors and begin implementing the new Basic* methods in the interim.
Jim
>>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 4/24/07 2:23 PM >>> Some pseudocode for use cases can be found at http://wiki.eclipse.org/index.php/IdAS_Update_Proposals#Use_Cases >>> "Jim Sermersheim" <jimse@xxxxxxxxxx> 4/24/07 10:59 AM >>> I've updated http://wiki.eclipse.org/index.php/IdAS_Update_Proposals_Distillation with what I believe to be general consensus thus far.
I'll move on to some use-case pseudo-code.
|