Re: [gemini-dev] Gemini DBAccess: MySQL Support

["Kissner, Juergen" <juergen.kissner@xxxxxxx>]

Hi Cristiano,

thank you for your interest in the project.

Yes, your participation is welcome! If you want to contribute, you should open a Bugzilla bug and attach a SVN patch to it.

Before you do that, please have a look at the information below:

http://www.eclipse.org/gemini/dbaccess/contribute/
http://www.eclipse.org/legal/committerguidelines.php
http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf

Gemini DBAccess is published under the EPL License, please refer to http://www.eclipse.org/legal/epl/notice.php. By submitting the patch, you have to agree to the terms and conditions of this license, otherwise you contribution cannot be accepted. Please also make sure that the company you are working for knows about your contribution and agrees to it (unless your contribution is unrelated to your work).

A patch should evolve the project in a clear-cut and incremental way. For example, one step (one patch) could be the migration to tycho 0.13, the next step could be to refer to the Maven repository for the build. By the way, osgi.enterprise can be taken from the Eclipse Orbit, we do not need the Maven repository for that.  

Have you noticed that I have already split the Derby and MySQL into two separate features?

Best Regards,
  Juergen 


-----Original Message-----
From: Cristiano Gavião [mailto:cvgaviao@xxxxxxxxx] 
Sent: Montag, 31. Oktober 2011 20:21
To: Kissner, Juergen
Subject: Re: Gemini DBAccess: MySQL Support

Hi Juergen,

I already did the improvements that you have referred: using tycho 
0.13.0, conversion of site project to p2 repo one, using the mysql, 
osgi.enterprise bundles from maven central repo.

how can I sent those changes to you ? svn patch ?

cheers

Cristiano

On 25/10/11 08:01, Kissner, Juergen wrote:
> I have submitted a DBAcccess version that contains support of MySQL. The artifacts and update site can be found here:
>
> https://hudson.eclipse.org/hudson/job/gemini-dbaccess-1.1-snapshot/
> https://hudson.eclipse.org/hudson/job/gemini-dbaccess-1.1-snapshot/lastSuccessfulBuild/artifact/trunk/gemini.dbaccess.updatesite/target/site/
>
>
> Because of the MySQL license, I haven't included the JDBC driver of MySQL. That means, you have to download it yourself and make it part of your target definition. Please do not select the option "Include required software" when you add the DBAccess Software Site to your target definition. Otherwise the import will complain about the missing dependencies.
>
> The project has been refactored: There is now a util bundle that contains the part common to the MySQL and the Derby support. If that is not feasible, we need to think of a way to re-package the bundles.
>
> There are still various bits and pieces that could be improved. For example, DBAccess could be using tycho 0.13, the osgi.enterprise API could be referenced instead of being included in the update site, ... Also it might be useful to create a separate Derby feature and MySQL feature instead of having a single one.
>
> Please let me know what your priorities are, and/or raise a bug.
>
> Best Regards,
>    Juergen