[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [equinox-dev] Configuration Admin bug

Oops, I made a mistake in the last run. I did not notice that there were two
cm bundles loaded and I was continuing to bind to the other one.

The new cm bundle provided by Thomas does not have the problem.

But I did notice one thing. When I changes the bundle for cm to the new
bundle, the old configurations that were stored were no longer visible. Is
that the behaviour you would expect? If so, that is a bad thing. At least it
is bad for us. We would need to ensure the configs get preserved across
updates to cm. If cm is completely replaced by a different implementation,
then of course you cannot expect the configs to be preserved.

Thanks!
-Don

On 12/6/07 2:28 PM, "Simon Kaegi" <Simon_Kaegi@xxxxxxxxxx> wrote:

> Don,
> 
> Could you provide a more detailed test case.
> The code specifically checks for a null BundleLocation so I suspect you're
> getting an NPE for another reason.
> 
> The code has been significantly refactored so that the relevant check I
> think you're referring to is now in
> org.eclipse.equinox.internl.cm.ConfigAdminImpl  line 48.
> 
> if (config.getBundleLocation() != null &&
> !config.getBundleLocation().equals(bundle.getLocation()))
> 
> Could you verify that this is still the NPE cause and if not it would be
> great to know where it's coming from.
> 
> Thanks.
> -Simon
> 
> equinox-dev-bounces@xxxxxxxxxxx wrote on 12/06/2007 02:08:52 PM:
> 
>> 
>> Yes, the problem still seems to be there in that version.
>> 
>> -Don
>> 
>> 
>> On 12/6/07 1:05 PM, "Thomas Watson" <tjwatson@xxxxxxxxxx> wrote:
> 
>> This has already been fixed in the latest version of CM.  Can you
>> try the latest build at
>> 
>> http://download.eclipse.
>> org/eclipse/equinox/drops/I20071204-1547/download.php?dropFile=org.
>> eclipse.equinox.cm_1.0.0.v20071203.jar
>> 
>> Tom
>> 
>> 
>> 
>> [image removed] "Laidlaw, Don" ---12/06/2007 11:32:36 AM---In org.
>> eclipse.equinox.cm.internal.ConfigurationAdminFactory at line 812.
>> 
>> [image removed]
>> From:[image removed]
>> "Laidlaw, Don" <don.laidlaw@xxxxxxxxx>
>> [image removed]
>> To:[image removed]
>> Equinox development mailing list <equinox-dev@xxxxxxxxxxx>
>> [image removed]
>> Date:[image removed]
>> 12/06/2007 11:32 AM
>> [image removed]
>> Subject:[image removed]
>> [equinox-dev] Configuration Admin bug
>> 
>> 
>> 
>> 
>> In org.eclipse.equinox.cm.internal.ConfigurationAdminFactory at line 812.
>> 
>> The line:
>>  if (!config.getBundleLocation().equals(bundle.getLocation()))
>> 
>> The config.getBundleLocation() can sometimes return null. This is
>> especially true in a new factory configuration created by an admin
>> bundle with a null location. So in this case it will throw NPE.
>> 
>> The workaround is to always provide a location, but this is not
>> required by the spec, and in fact you may want to create the
>> configuration before the bundle is installed.
>> 
>> Don Laidlaw | Sr. Research Engineer | Infor | office: 905-305-7307 |
>> mobile: 416-543-1085 | don.laidlaw@xxxxxxxxx
>> _______________________________________________
>> equinox-dev mailing list
>> equinox-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/equinox-dev
>> 
>> 
>> _______________________________________________
>> equinox-dev mailing list
>> equinox-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/equinox-dev
>> 
>> 
>> Don Laidlaw | Sr. Research Engineer | Infor | office: 905-305-7307 |
>> mobile: 416-543-1085 | don.laidlaw@xxxxxxxxx
>> _______________________________________________
>> equinox-dev mailing list
>> equinox-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/equinox-dev
> 
> _______________________________________________
> equinox-dev mailing list
> equinox-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/equinox-dev

Don Laidlaw | Sr. Research Engineer | Infor | office: 905-305-7307 | mobile:
416-543-1085 | don.laidlaw@xxxxxxxxx