Re: [egit-dev] locking mechanism

[Matthias Sohn <matthias.sohn@xxxxxxxxx>]

On Thu, Dec 19, 2013 at 11:24 AM, Laurent Goubet <laurent.goubet@xxxxxxx> wrote:

A very small note :

On 19/12/2013 11:11, Matthias Sohn wrote:

I don't use the commit dialog anymore since a long time, do we still need a second way to commit
behaving differently and non-git-ish ? We could simply delete the CommitDialog and open
the staging view when a user clicks "Commit..."

+1 on that, users have currently no way to "discover" that view, even though it is much more useful than the commit dialog.

For reference, you might also want to look at comment 7 on 418708 : bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=418708#c7 . I don't know if David Williams is a big user if EGit, but he obviously didn't know about that view. (Though that bug also outlines a problem with the staging view with autocrlf... though the commit dialog "undestands" that there is no change to commit if a file only has EOL changes with autocrlf=false ... the staging view does not.)

We had merged https://git.eclipse.org/r/#/c/19397/ to fix this but unfortunately this caused

a regression by the newly introduced "unsmudging" of DirCache entries (see [1]) causing wrong

git status in some cases so we had to revert this fix until the regression is fixed.

[1] https://github.com/git/git/blob/master/Documentation/technical/racy-git.txt

--

Matthias