[egit-dev] Re: [master] Change I184c1ab2: (egit) Re-inserted the non jav

[Wim Jongman <wim.jongman@xxxxxxxxx>]

Hi Matthias,

I see what i have done wrong but how can I push this change again? 

> I suggest to update the commit message you had in 269

how by using commit and amend in eclipse teaming? and then git push ssh://wimjongman@xxxxxxxxxxxxxxxx:29418/egit.git HEAD:refs/for/master

That did not work either, caused again a new change to appear.

Sorry for being so clumsy. I could use some help..

Regards,

Wim

On Wed, Mar 3, 2010 at 11:53 PM, Matthias Sohn (Code Review) <codereview-daemon@xxxxxxxxxxx> wrote:

Comments on Patch Set 1:

Patch Set 1: I would prefer that you didn't submit this; No score

I guess you probably wanted to replace http://egit.eclipse.org/r/#change,269.
What you did put into the new commit message should have rather gone into the cover message in gerrit. The commit message should explain the "why" but not the delta to the previous patch set for the same change. I suggest to update the commit message you had in 269 and push this change as new patch set for 269. Let me know if you need help for that.

To respond, visit http://egit.eclipse.org/r/327

--
To view visit http://egit.eclipse.org/r/327
To unsubscribe, visit http://egit.eclipse.org/r/settings

Gerrit-MessageType: comment

Gerrit-Project: egit
Gerrit-Branch: master