Re: [egit-dev] tycho build

[Igor Fedorenko <ifedorenko@xxxxxxxxxxxx>]

Thank you, Matthias.

I've tried to add my changes to http://egit.eclipse.org/r/#change,131
but for whatever reason gerrit ignored Change-Id I provided and created
new change http://egit.eclipse.org/r/#change,134. Not quite sure if I
did something wrong or if this is a gerrit bug/feature.

--
Regards,
Igor

Sohn, Matthias wrote:
> Igor Fedorenko <igor@xxxxxxxxxxxxxx> wrote:
> > Yes, the patch does make sense and I will appreciate if you can push it
> > to gerrit. Given my absolute lack of knowledge of git and gerrit (case
> > in point, I could not even apply the patch to my local repository), I
> > think this is safest and fastest way to get these changes in.
>
> I pushed the squashed patch to gerrit at http://egit.eclipse.org/r/#change,131
>
> Igor, please abandon your old changes this new one replaces :
> http://egit.eclipse.org/r/#change,126  Change Icebfffdc: partially working tycho build configuration
> http://egit.eclipse.org/r/#change,127  Change Ic384b918: Merge commit 'origin'
> http://egit.eclipse.org/r/#change,129  Change Ia9f596ab: Merge commit 'origin'
> http://egit.eclipse.org/r/#change,130  Change I6198622b: New org.sonatype.tycho groupId..
> http://egit.eclipse.org/r/#change,128  Change I1cd9ec0f: flipped jgit.core to manifest-first
>
> and add whatever is pending from the comments on http://egit.eclipse.org/r/#change,128 
> and review the commit message again. If you need more description how to contribute
> have a look at http://wiki.eclipse.org/EGit/Contributor_Guide. 
>
> --
> Matthias
> _______________________________________________
> egit-dev mailing list
> egit-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/egit-dev