Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Getting a better understanding of ReflogConfigTest.testlogAllRefUpdates()
Shawn,

>These timezones of -21000000 are bogus.  WTF?

>On Linux I'm getting what we would expect given MockSystemReader's
>getTimezone is GMT-03:30, the timezone is -330:
I've pulled latest version and managed to reproduce the bug. However, it looks like some Java/OS related bug.
In order to give you a first idea, I've attached a screenshot.
 
For your information, I'm running Windows 7. What kind of information could I send you to help you troubleshooting the issue ?

Note : as I do not know if egit-dev list filters out images, I cc this on your personal email address.

Em.


On Thu, Nov 5, 2009 at 3:56 AM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
Emeric Fermas <emeric.fermas@xxxxxxxxx> wrote:
> I'm a GitSharp project committer and porting this test to .net raised
> some questions that I'd like to share with you.
>
> 1. commitTime and tz are fixed and used to fill PersonIdent instances.
> However, RefLogWriter ends up with relying on a mocked SystemReader to
> retrieve a fake current dateTime.

True.  These two local variables are used for the commit object's
author/committer headers, not for the reflog records.  Its confusing,
I know, this test was constructed only to care about whether or
not records were written, not what they contained.

> 2. When being run on Windows through Eclipse this test generates a log
> file (cf. attachment) where TimeZones are weirdly formatted.
>
> 803aec4aba175e8ab1d666873c984c0308179099 6a2d9b1f7f4bba043ec7f4c52f04f8ab57829e3d GIT_COMMITTER_NAME <GIT_COMMITTER_EMAIL> 1250379778 -21000000       commit : A Commit
> 6a2d9b1f7f4bba043ec7f4c52f04f8ab57829e3d bd701ad4d0c259e5a5f728b0f601d6d5b02ffb5d GIT_COMMITTER_NAME <GIT_COMMITTER_EMAIL> 1250379778 -21000000       commit : A Commit

These timezones of -21000000 are bogus.  WTF?

On Linux I'm getting what we would expect given MockSystemReader's
getTimezone is GMT-03:30, the timezone is -330:

803aec4aba175e8ab1d666873c984c0308179099 6a2d9b1f7f4bba043ec7f4c52f04f8ab57829e3d GIT_COMMITTER_NAME <GIT_COMMITTER_EMAIL> 1250379778 -0330     commit : A Commit
6a2d9b1f7f4bba043ec7f4c52f04f8ab57829e3d bd701ad4d0c259e5a5f728b0f601d6d5b02ffb5d GIT_COMMITTER_NAME <GIT_COMMITTER_EMAIL> 1250379778 -0330     commit : A Commit

--
Shawn.
_______________________________________________
egit-dev mailing list
egit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/egit-dev

Attachment: timezone.bug.png
Description: PNG image

Back to the top